From b102bb7c96856efb89151ae841a7ffe9498a3b52 Mon Sep 17 00:00:00 2001
From: Pranav Sharma <83678994+spran180@users.noreply.github.com>
Date: Wed, 31 Jul 2024 13:00:21 +0530
Subject: [PATCH] gh-752: Added more Tests for Moving Histogram Algorithm

---
 src/tests/roc_core/test_mov_histogram.cpp | 140 ++++++++++++++++++++++
 1 file changed, 140 insertions(+)

diff --git a/src/tests/roc_core/test_mov_histogram.cpp b/src/tests/roc_core/test_mov_histogram.cpp
index 6473181c7..637e1900d 100644
--- a/src/tests/roc_core/test_mov_histogram.cpp
+++ b/src/tests/roc_core/test_mov_histogram.cpp
@@ -101,5 +101,145 @@ TEST(movhistogram, value_equal_to_value_range_max) {
     LONGS_EQUAL(1, hist.get_bin_counter(expected_bin_index));
 }
 
+TEST(movhistogram, value_is_float) {
+    const float value_range_min = 0.0f;
+    const float value_range_max = 100.0f;
+    const size_t num_bins = 10;
+    const size_t win_length = 10;
+
+    MovHistogram<float> hist(arena, value_range_min, value_range_max, num_bins,
+                             win_length);
+    CHECK(hist.is_valid());
+
+    for (size_t i = 0; i < win_length; i++) {
+        hist.add_value(i * num_bins * 1.0f);
+    }
+
+    for (size_t i = 0; i < num_bins; ++i) {
+        LONGS_EQUAL(1, hist.get_bin_counter(i));
+    }
+}
+
+TEST(movhistogram, min_max_negative) {
+    const int value_range_min = -150;
+    const int value_range_max = -50;
+    const size_t num_bins = 10;
+    const size_t win_length = 10;
+
+    MovHistogram<int> hist(arena, value_range_min, value_range_max, num_bins, win_length);
+    CHECK(hist.is_valid());
+
+    const int bin_width = (value_range_max - value_range_min) / (int)(num_bins);
+
+    for (size_t i = 0; i < win_length; i++) {
+        int value = value_range_min + (int)i * bin_width;
+        hist.add_value(value);
+    }
+
+    for (size_t i = 0; i < num_bins; ++i) {
+        LONGS_EQUAL(1, hist.get_bin_counter(i));
+    }
+}
+
+TEST(movhistogram, win_length_equal_one) {
+    const size_t value_range_min = 0;
+    const size_t value_range_max = 100;
+    const size_t num_bins = 10;
+    const size_t win_length = 1;
+
+    MovHistogram<size_t> hist(arena, value_range_min, value_range_max, num_bins,
+                              win_length);
+    CHECK(hist.is_valid());
+
+    hist.add_value(0);
+    hist.add_value(10);
+    hist.add_value(20);
+
+    LONGS_EQUAL(0, hist.get_bin_counter(0));
+    LONGS_EQUAL(0, hist.get_bin_counter(1));
+    LONGS_EQUAL(1, hist.get_bin_counter(2));
+}
+
+TEST(movhistogram, multiple_values_in_bins) {
+    const size_t value_range_min = 0;
+    const size_t value_range_max = 100;
+    const size_t num_bins = 10;
+    const size_t win_length = 50;
+
+    MovHistogram<size_t> hist(arena, value_range_min, value_range_max, num_bins,
+                              win_length);
+    CHECK(hist.is_valid());
+
+    const size_t values_per_bin = 5;
+    const size_t total_values = num_bins * values_per_bin;
+
+    for (size_t i = 0; i < total_values; ++i) {
+        size_t value = (i / values_per_bin) * (value_range_max / num_bins);
+        hist.add_value(value);
+    }
+
+    for (size_t i = 0; i < num_bins; ++i) {
+        LONGS_EQUAL(values_per_bin, hist.get_bin_counter(i));
+    }
+}
+
+TEST(movhistogram, rolling_window_bin_changes) {
+    const size_t value_range_min = 0;
+    const size_t value_range_max = 100;
+    const size_t num_bins = 10;
+    const size_t win_length = 5;
+
+    MovHistogram<size_t> hist(arena, value_range_min, value_range_max, num_bins,
+                              win_length);
+    CHECK(hist.is_valid());
+
+    for (size_t i = 0; i < win_length; i++) {
+        hist.add_value(i * (value_range_max / num_bins));
+    }
+
+    for (size_t i = 0; i < num_bins; i++) {
+        LONGS_EQUAL(i < win_length ? 1 : 0, hist.get_bin_counter(i));
+    }
+
+    hist.add_value(win_length * (value_range_max / num_bins));
+
+    for (size_t i = 0; i < num_bins; i++) {
+        if (i < 1) {
+            LONGS_EQUAL(0, hist.get_bin_counter(i));
+        } else if (i <= win_length) {
+            LONGS_EQUAL(1, hist.get_bin_counter(i));
+        } else {
+            LONGS_EQUAL(0, hist.get_bin_counter(i));
+        }
+    }
+}
+
+TEST(movhistogram, clamping_values) {
+    const size_t value_range_min = 50;
+    const size_t value_range_max = 150;
+    const size_t num_bins = 10;
+    const size_t win_length = 10;
+
+    MovHistogram<size_t> hist(arena, value_range_min, value_range_max, num_bins,
+                              win_length);
+    CHECK(hist.is_valid());
+
+    hist.add_value(static_cast<size_t>(20));
+    hist.add_value(static_cast<size_t>(5));
+    hist.add_value(static_cast<size_t>(10));
+
+    hist.add_value(static_cast<size_t>(60));
+    hist.add_value(static_cast<size_t>(80));
+
+    hist.add_value(static_cast<size_t>(160));
+    hist.add_value(static_cast<size_t>(170));
+    hist.add_value(static_cast<size_t>(180));
+
+    LONGS_EQUAL(3, hist.get_bin_counter(0));
+    LONGS_EQUAL(1, hist.get_bin_counter(1));
+    LONGS_EQUAL(1, hist.get_bin_counter(3));
+    LONGS_EQUAL(3, hist.get_bin_counter(9));
+}
+
 } // namespace core
 } // namespace roc