some fixes

* viewDidMoveToWindow is also called when a view is removed from superview, so window() is None and no wrapper needs to call positionViews
* VanillaTabsDelegate is gone, all delegate actions goes to the controller, which is already set. Every tabView has already a delegate
* Removing some unnecessary imports and attributes
* Adding doc strings

Author: typemytype

Lib/vanilla/vanillaTabs.py

@@ -1,4 +1,3 @@
-import weakref
 from Foundation import NSObject
 from AppKit import NSViewController,\
     NSTabViewController, NSTabView, NSTabViewItem,\
@@ -15,15 +14,16 @@
     NSViewControllerTransitionSlideBackward,\
     NSFont
 from vanilla.vanillaBase import VanillaBaseObject, _breakCycles, _sizeStyleMap, VanillaCallbackWrapper, \
-        _reverseSizeStyleMap
+    _reverseSizeStyleMap
 from vanilla.nsSubclasses import getNSSubclass
 
 
 class VanillaTabView(NSTabView):
 
     def viewDidMoveToWindow(self):
-        wrapper = self.vanillaWrapper()
-        wrapper._positionViews()
+        if self.window() is not None:
+            wrapper = self.vanillaWrapper()
+            wrapper._positionViews()
         super().viewDidMoveToWindow()
 
 
@@ -125,6 +125,30 @@ def __init__(self):
     +-----------+
     | "mini"    |
     +-----------+
+
+    **showTabs** Boolean representing if the tabview should display tabs.
+
+    **transitionStyle** A string rerpresenting a transition style between tabs.
+    The options are:
+
+    +-----------------+
+    | None            |
+    +-----------------+
+    | "crossfade"     |
+    +-----------------+
+    | "slideUp"       |
+    +-----------------+
+    | "slideDown"     |
+    +-----------------+
+    | "slideLeft"     |
+    +-----------------+
+    | "slideRight"    |
+    +-----------------+
+    | "slideForward"  |
+    +-----------------+
+    | "slideBackward" |
+    +-----------------+
+
     """
 
     nsTabViewClass = VanillaTabView
@@ -153,7 +177,6 @@ def __init__(self, posSize, titles=["Tab"], callback=None, sizeStyle="regular",
         self._setSizeStyle(sizeStyle)
         self._tabViewController.setTransitionOptions_(_tabTransitionMap[transitionStyle])
         self._tabItems = []
-        contentRect = self._nsObject.contentRect()
         for title in titles:
             tab = self.vanillaTabItemClass(title)
             self._tabItems.append(tab)
@@ -192,9 +215,6 @@ def _setCallback(self, callback):
         if callback is not None:
             self._target = VanillaCallbackWrapper(callback)
             delegate = self._nsObject.delegate()
-            if delegate is None:
-                self._delegate = delegate = getNSSubclass(VanillaTabsDelegate).alloc().init()
-                self._nsObject.setDelegate_(delegate)
             delegate._target = self._target
 
     def _setSizeStyle(self, value):