Add support for both Gazebo Harmonic (gz-sim8) and Gazebo Ionic (gz-sim9) #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
force-pushed
the
pixisupportionic
branch
4 times, most recently
from
51c800f
to
44ca8ff
Compare
|
A bunch of tests are passing fine on macos in I can try at some point to run them locally on my mac mini. |
traversaro
force-pushed
the
pixisupportionic
branch
from
44ca8ff
to
6550510
Compare
traversaro
force-pushed
the
pixisupportionic
branch
from
6550510
to
1a02165
Compare
traversaro
changed the title
traversaro
changed the title
|
The error message (at least for some tests) is: Note that all the newlines are not an error, it seems that somehow gz-rendering is trying to load the plugin
|
|
In ogre-next 2.3.3 indeed the file |
These 3D graphics issues will kill me someday 😭 |
5 tasks
|
The problematic call seems https://github.com/gazebosim/gz-rendering/blob/gz-rendering9_9.0.0/ogre2/src/Ogre2RenderEngine.cc#L685, where for some reason |
|
|
5 tasks
|
I think I was barking at the wrong tree. Even by loading is printed, probably because the hardcoded plugin path in code is malformed or not working somehow, but then the engine is actually loaded correctly, probably thanks to the |
|
My guess is that there is some race condition between the rendering and sensor systems, this is the bt for the failing lasertest: |
|
Almost all tests that crash crash with final message: so I guess that there is some problem in trying to stop the sensors if the "Rendering Thread initialized" state of the sensors system was not reached. |
|
The failure in Ionic/macOS may not be immediate to fix. As most users are on Linux, I think we can disable the tests on macOS for now and track fixing the actual tests in a separate issue. |
|
I think this is ready for review, we can track future work in |
xela-95
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Thanks a lot @traversaro ! Amazing work both on CMake and pixi!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #209 .
Requires #214 to be merged before (and eventually rebased).
The
defaultpixi environment still uses Harmonic/gz-sim8, while theionicenvironment usedIonic/gz-sim9. If both gz-sim8 and gz-sim9 are available in the system, at the moment CMake prefers gz-sim8, unless the users does not explicitly select the 9 by setting theGZ_SIM_YARP_PLUGINS_USED_GZ_SIM_VERSIONto 9 during CMake configuration.