feat(langserver): show variable type in hover for RF 7.3

Author: d-biehl

packages/language_server/src/robotcode/language_server/robotframework/parts/hover.py

@@ -163,7 +163,7 @@ def _hover_default(self, nodes: List[ast.AST], document: TextDocument, position:
                     else:
                         value = ""
 
-                    text = f"### {variable.type.value.title()} `{variable.name}`\n\n"
+                    text = f"### {variable.type.value.title()} `{variable.full_name}`\n\n"
 
                     if value:
                         text += "```python\n"

packages/robot/src/robotcode/robot/diagnostics/entities.py

@@ -19,7 +19,7 @@
 from robotcode.core.lsp.types import Position, Range
 
 from ..utils.ast import range_from_token
-from ..utils.variables import VariableMatcher
+from ..utils.variables import VariableMatcher, search_variable
 
 if TYPE_CHECKING:
     from robotcode.robot.diagnostics.library_doc import KeywordDoc, LibraryDoc
@@ -191,7 +191,13 @@ class VariableDefinition(SourceEntity):
 
     @functools.cached_property
     def matcher(self) -> VariableMatcher:
-        return VariableMatcher(self.name)
+        return search_variable(self.name)
+
+    @functools.cached_property
+    def full_name(self) -> str:
+        m = self.matcher
+        value_type = f": {self.value_type}" if self.value_type else ""
+        return f"{m.identifier}{{{m.base.strip()}{value_type}}}"
 
     @single_call
     def __hash__(self) -> int:

tests/robotcode/language_server/robotframework/parts/_regtest_outputs/rf41/test_references.test[references.robot-036-004-simple_keyword_call].out

@@ -223,46 +223,55 @@ result:
   range:
     end:
       character: 7
-      line: 8
+      line: 10
     start:
       character: 4
-      line: 8
+      line: 10
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 9
+      line: 11
     start:
       character: 4
-      line: 9
+      line: 11
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 10
+      line: 12
     start:
       character: 4
-      line: 10
+      line: 12
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 20
+      line: 13
     start:
       character: 4
-      line: 20
+      line: 13
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 21
+      line: 14
     start:
       character: 4
-      line: 21
+      line: 14
+  uri: rf73/variable_conversion.robot
+- !Location
+  range:
+    end:
+      character: 7
+      line: 15
+    start:
+      character: 4
+      line: 15
   uri: rf73/variable_conversion.robot
 - !Location
   range:
@@ -273,95 +282,122 @@ result:
       character: 4
       line: 25
   uri: rf73/variable_conversion.robot
+- !Location
+  range:
+    end:
+      character: 7
+      line: 26
+    start:
+      character: 4
+      line: 26
+  uri: rf73/variable_conversion.robot
+- !Location
+  range:
+    end:
+      character: 7
+      line: 30
+    start:
+      character: 4
+      line: 30
+  uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 11
-      line: 31
+      line: 36
     start:
       character: 8
-      line: 31
+      line: 36
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 11
-      line: 35
+      line: 40
     start:
       character: 8
-      line: 35
+      line: 40
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 40
+      line: 45
     start:
       character: 4
-      line: 40
+      line: 45
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 47
+      line: 55
     start:
       character: 4
-      line: 47
+      line: 55
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 48
+      line: 56
     start:
       character: 4
-      line: 48
+      line: 56
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 49
+      line: 57
     start:
       character: 4
-      line: 49
+      line: 57
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 50
+      line: 58
     start:
       character: 4
-      line: 50
+      line: 58
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 54
+      line: 62
     start:
       character: 4
-      line: 54
+      line: 62
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 55
+      line: 63
     start:
       character: 4
-      line: 55
+      line: 63
+  uri: rf73/variable_conversion.robot
+- !Location
+  range:
+    end:
+      character: 7
+      line: 67
+    start:
+      character: 4
+      line: 67
   uri: rf73/variable_conversion.robot
 - !Location
   range:
     end:
       character: 7
-      line: 59
+      line: 80
     start:
       character: 4
-      line: 59
+      line: 80
   uri: rf73/variable_conversion.robot
 - !Location
   range: