Skip to content

Commit

Permalink
[WANROUTER]: Use proc_create() to setup ->proc_fops first
Browse files Browse the repository at this point in the history
Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wang Chen authored and davem330 committed Feb 28, 2008
1 parent d45fba3 commit 6d37a15
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions net/wanrouter/wanproc.c
Original file line number Diff line number Diff line change
Expand Up @@ -292,14 +292,12 @@ int __init wanrouter_proc_init(void)
if (!proc_router)
goto fail;

p = create_proc_entry("config", S_IRUGO, proc_router);
p = proc_create("config", S_IRUGO, proc_router, &config_fops);
if (!p)
goto fail_config;
p->proc_fops = &config_fops;
p = create_proc_entry("status", S_IRUGO, proc_router);
p = proc_create("status", S_IRUGO, proc_router, &status_fops);
if (!p)
goto fail_stat;
p->proc_fops = &status_fops;
return 0;
fail_stat:
remove_proc_entry("config", proc_router);
Expand Down Expand Up @@ -329,10 +327,10 @@ int wanrouter_proc_add(struct wan_device* wandev)
if (wandev->magic != ROUTER_MAGIC)
return -EINVAL;

wandev->dent = create_proc_entry(wandev->name, S_IRUGO, proc_router);
wandev->dent = proc_create(wandev->name, S_IRUGO,
proc_router, &wandev_fops);
if (!wandev->dent)
return -ENOMEM;
wandev->dent->proc_fops = &wandev_fops;
wandev->dent->data = wandev;
return 0;
}
Expand Down

0 comments on commit 6d37a15

Please sign in to comment.