Skip to content

Commit

Permalink
ASoC: wm8711: fix a memory leak if another WM8711 is registered
Browse files Browse the repository at this point in the history
wm8711 is allocated in either wm8711_spi_probe() or wm8711_i2c_probe() but is
not freed if wm8711_register() return -EINVAL(if another ad1836 is registered).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
AxelLin authored and broonie committed Aug 3, 2010
1 parent ef99e9b commit 2c2749d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sound/soc/codecs/wm8711.c
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,8 @@ static int wm8711_register(struct wm8711_priv *wm8711,

if (wm8711_codec) {
dev_err(codec->dev, "Another WM8711 is registered\n");
return -EINVAL;
ret = -EINVAL;
goto err;
}

mutex_init(&codec->mutex);
Expand Down

0 comments on commit 2c2749d

Please sign in to comment.