Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metrics naming doesn't follow the convention #706

Open
maxkrivich opened this issue Mar 9, 2021 · 1 comment
Open

Prometheus metrics naming doesn't follow the convention #706

maxkrivich opened this issue Mar 9, 2021 · 1 comment

Comments

@maxkrivich
Copy link

maxkrivich commented Mar 9, 2021

Just want to raise a general concern about namings and units which are used in the PrometheusMonitor class to expose metrics. You are not obligated to follow the naming convention but it is highly recommended by the Prometheus team.

Things to take a look at:

  1. namespaces
  2. base units
  3. metrics naming

Link on the official Prometheus documentation:
https://prometheus.io/docs/practices/naming/

@Kuzyashin
Copy link
Contributor

HI! Check same feature here : faust-streaming/faust#120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants