Some enhancements #103
Merged
Some enhancements #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bgaifullin
commented
Apr 5, 2017
bgaifullin
commented
- added messages for test asserts
- modified condition to select expired jobs instead of exact match
- optimisation: did re-create timer on request for snapshot
Select all exprired jobs instead of exact match job next time running time.
Snapshot requests is read-only operation, so it is not necessary to re-order tasks and reset timer
|
@robfig could you please review this PR ? |
robfig
reviewed
May 22, 2017
| @@ -221,7 +220,7 @@ func TestLocalTimezone(t *testing.T) { | |||
| wg := &sync.WaitGroup{} | |||
| wg.Add(2) | |||
|
|
|||
| now := time.Now().Local() | |||
| now := time.Now() | |||
There was a problem hiding this comment.
what is the purpose of this change?
There was a problem hiding this comment.
since time.Now() is local time already, so it is not need to call .Local()
|
Ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.