New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A trivial mistake in the code comment #399

Open

dushaoshuai opened this issue Jun 26, 2021 · 1 comment

dushaoshuai commented Jun 26, 2021

Line 193 in ccba498

// Entry returns a snapshot of the given entry, or nil if it couldn't be found.

func (c *Cron) Entry(id EntryID) Entry {
	for _, entry := range c.Entries() {
		if id == entry.ID {
			return entry
		}
	}
	return Entry{}
}

The zero value for a struct is not nil.

Owner

robfig commented Oct 1, 2021

I agree.. I would merge a PR fixing it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment