test(git): refactor testcase with goconvey

before: TestInstallSubCmd use with testing library
after: git.install and git.util some testcase use goconvey
goal: goconvey provide BDD style testcase which allows you write testcase more clearly

Author: robertzwj

git/install_test.go

@@ -1,57 +1,27 @@
 /*
  * @Author: robert zhang <robertzhangwenjie@gmail.com>
  * @Date: 2022-08-06 16:52:22
- * @LastEditTime: 2022-09-03 17:24:07
+ * @LastEditTime: 2022-09-04 11:37:33
  * @LastEditors: robert zhang
  * @Description:
  */
 package git
 
 import (
-	"os"
-	"path/filepath"
 	"testing"
+
+	. "github.com/glycerine/goconvey/convey"
 )
 
 func TestInstallSubCmd(t *testing.T) {
-	type args struct {
-		filePath   string
-		subCmdName string
-	}
-
-	testcases := []struct {
-		name    string
-		args    args
-		wantErr bool
-	}{
-		{
-			name: "noExistFile",
-			args: args{
-				filePath:   "/123/456",
-				subCmdName: "123",
-			},
-			wantErr: true,
-		},
-		{
-			name: "normalFile",
-			args: args{
-				filePath:   filepath.Join("testdata", "testcmd"),
-				subCmdName: "testcmd",
-			},
-			wantErr: false,
-		},
-	}
-
-	for _, tc := range testcases {
-		t.Run(tc.name, func(t *testing.T) {
-			dstFilePath, err := InstallSubCmd(tc.args.filePath, tc.args.subCmdName)
-			if err == nil {
-				os.Remove(dstFilePath)
-			}
-			if (err != nil) != tc.wantErr {
-				t.Errorf("InstallSubCmd() error = %v,wantErr %v ", err, tc.wantErr)
-			}
-
+	Convey("Given a file which doesn't exist", t, func() {
+		filepath := "/123/456"
+		subCmdName := "123"
+		Convey("When install it as git subcommand", func() {
+			_, err := InstallSubCmd(filepath, subCmdName)
+			Convey("Then should return err", func() {
+				So(err, ShouldNotBeNil)
+			})
 		})
-	}
+	})
 }

git/util_test.go

@@ -1,16 +1,20 @@
 /*
  * @Author: robert zhang <robertzhangwenjie@gmail.com>
  * @Date: 2022-08-07 18:14:41
- * @LastEditTime: 2022-08-10 15:09:22
+ * @LastEditTime: 2022-09-04 11:20:49
  * @LastEditors: robert zhang
  * @Description:
  */
 package git
 
 import (
+	"os"
 	"os/exec"
+	"path/filepath"
 	"strings"
 	"testing"
+
+	. "github.com/glycerine/goconvey/convey"
 )
 
 func TestExecPath(t *testing.T) {
@@ -27,29 +31,25 @@ func TestExecPath(t *testing.T) {
 }
 
 func TestIsGitRepository(t *testing.T) {
-	testcases := []struct {
-		name string
-		path string
-		want bool
-	}{
-		{
-			name: "invalid path",
-			path: "ttttt/",
-			want: false,
-		},
-		{
-			name: "current path",
-			path: ".",
-			want: true,
-		},
-	}
+	Convey("Given a path", t, func() {
+		var path string
+		Convey("When it doestn't exist", func() {
+			path = "testdata/xxx"
+			Convey("Then should return false", func() {
+				So(IsGitRepository(path), ShouldBeFalse)
+			})
+		})
 
-	for _, tc := range testcases {
-		t.Run(tc.name, func(t *testing.T) {
-			got := IsGitRepository(tc.path)
-			if got != tc.want {
-				t.Errorf("expected %v, got %v", tc.want, got)
+		Convey("When it's a git repo", func() {
+			path = filepath.Join("testdata", "gitrepo")
+			if err := exec.Command("git", "init", path).Run(); err != nil {
+				t.Errorf("git init failed: %v", err)
 			}
+			defer os.RemoveAll(path)
+
+			Convey("Then should return true", func() {
+				So(IsGitRepository(path), ShouldBeTrue)
+			})
 		})
-	}
+	})
 }