split out httpserver.middleware into a new sub-package, with improved API #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
robbyt
force-pushed
the
rterhaar/middleware-simplify
branch
from
61254b6 to
2ab92c5
Compare
robbyt
force-pushed
the
rterhaar/middleware-simplify
branch
from
26e808f to
81cec02
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight breaking change to the
httpserverif you used the middleware system. It changes from the previous function wrappers to a handler chain, which is a pattern inspired by Gin. This makes it easier to implement external middleware packages.All middleware now shares the
httpserver.HandlerFuncsignature and uses aRequestProcessorfor request flow control. Existing middleware (logger, recovery, metrics, state, wildcard) have been updated.The Route struct now stores handler chains instead of wrapped functions, and route creation uses
NewRouteFromHandlerFuncas the primary constructor.