Add mergeOfflineRegions method to enable side-loading tiles #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
mergeOfflineRegionsmethod to the offline manager. Tested and working on iOS and Android.I decided to use the name
mergeOfflineRegions(which is what it's called in the Android SDK) because it made more sense to me than naming itaddContentsOfFileoraddContentsOfURL(as it's called in the iOS SDK).I originally started making an example to demonstrate it in the example app, but since the side-loaded database must be generated using the same version of the Mapbox SDK that the client is using, such an example would break whenever we update either of our iOS or Android SDK versions.
This resolves #574.