-
-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 8.1.0-rc: Xcode 'Archive' produces a corrupt archive #1097
Comments
The Archive build gets corrupted again if I set Mapbox iOS SDK to 6.X version (using It's quite annoying as 5.9 has a symbols flickering while zooming out issue, which 5.8 didn't have, and it's fixed in 6.X. |
It's strange that the app builds fine with all Mapbox iOS SDK versions for Debug and Release, but with Archive it becomes corrupted (except with 5.9.0). When I peek inside the generated .xcarchive file that Archive creates, I see that the 'corrupted ones' lack Info.plist file and SCMBlueprint folder with .xcscmblueprint file inside it. Also BCSymbolsMaps folder seems to have less items. The Archive process completes without any errors. It does have a lot of warnings, but they look like kind of "normal" for React Native builds. |
I can confirm that is also happening with rc6 and rc9 |
I've noticed a similar issue on AppCenter:
Tried pinning to
If I downgrade to |
I guess a possible, even likely (?) explanation is that in rc4 the Mapbox SDK version was defined without a patch number, and now resolves to the highest minor version, i.e. 5.9.0. (rc4 to rc5 diff) |
I've been struggling with this too for a bit, and I found that downgrading cocoapods from version 1.10.0 to 1.9.3 fixed the corrupt archive issues above. The command I used:
|
We had similar issues with react-native-mapbox-gl 8.0.0 and the cocoapods downgrade to 1.9.3 resolved those as well. 1.10.0 did not create a valid archive. |
I've tried downgrading our |
Yes Appcenter does not respect the Podfile.lock version and will use whatever is installed to the runner machine. And the version was just upgraded to 1.10.0 and that is when my problems started. I used this script to enforce to use the version defined in the Podfile.lock. Which is in general better because now I can be in control what is used. |
Turns out that it's possible use Mapbox iOS SDK 6.X and avoid corruption with Previously I pinned to exact version |
Downgrading to cocoapods |
I have the same problem. Downgrading is working for me too |
Downgrading to Cocoapods |
Going back to 1.9.3 fixed it for us too |
Quick note for other folks looking for this: I was able to get this working without overwriting my global cocoapods install by using a Gemfile with the following contents in the RN
Then instead of the usual |
There is a conflicting issue with the latest AppCenter packages though as they require |
Any news on this? I keep using 1.9.3 for this project and 1.10.1 for my other projects |
Was somebody able to report this issue in the cocoapods repository? I cant find any related issues 😞 |
after running
after following these steps and run the commad ruby version - 3.0.0 cocoapods - 1.9.3 |
Using COCOAPODS: 1.10.1 and @react-native-mapbox-gl/maps": "8.1.0" I had the exact same problem (archive succeed but actually malformed) Just open the xcarchive and you'll see there are missing parts (the plist for example). The trick for me was to remove the copy dsym build phase of the @react-native-mapbox-gl-mapbox-static pod This phase was causing build failure with some config and malformed archive with others, I don't really get the crux of the problem but may be it can help some of you... |
The root cause for the malformed archive is probably this: CocoaPods/CocoaPods#10385 |
thanks @acecilia it really looks like the same problems, I'll give a try to your workaround |
no not able to see facing same issue posted over here |
|
@acaraty - can you explain from where it is resolved - The trick for me was to remove the copy dsym build phase of the @react-native-mapbox-gl-mapbox-static pod ? |
Same issue as @SebiVPS ! archive builds and available but error when uploading to app store:
|
I meant if you have |
@SebiVPS One way to verify the fix work is check if MapboxMobileEvents is actually being included as a framework per my comment here https://github.com/react-native-mapbox-gl/maps/issues/1097#issuecomment-788180364. Maybe it doesn't work with certain cocoapod version? What version are you using? |
I would like to again bring attention to comment by @sampok
I can only confirm that 6.2.2 or 6.3.3 version have still issue with corrupted archive. |
Thank you for your comments, i tried using Currently i get an error at
|
Hmm upgrading cocoapods to 1.10.2, upgrading mapboxgl to 8.2.0-beta1 and adding pre and post install methods in podfile solved this for me. |
@SebiVPS In order to use new Mapbox SDK you need to have a special password in .netrc. Please refer to Mapbox iOS SDK fo more info. # Add Mapbox password to .netrc in order to download iOS SDK
echo -e "machine $NETRC_MAPBOX_MACHINE\nlogin $NETRC_MAPBOX_LOGIN\npassword $NETRC_MAPBOX_PASSWORD" > ~/.netrc |
I tested this patch on cocoapods 1.10.x so maybe it doesn't work on 1.9.x. Maybe it is possible to get it to work on 1.9.x or document the requirement of using 1.10.x |
Thank you for pointing me in the right direction :) |
Dear @mfazekas, I tried this solution. Archive and build success. Error:
|
I'm getting the same problem of @bdtren with 8.2.0-beta1 version and the pre_install and post_install tasks on my Podfile |
I get a corrupt archive and keep getting this error when trying to upgrade to 8.2.0-beta1:
Can someone let me know how to solve this. |
I have the same corrupted archive problem with "@react-native-mapbox-gl/maps": "^8.1.0-beta.1". Upgrading to latest versions also breaks my build for hooks dependancies. |
@SebiVPS How did you get 8.2.0-beta1 to install on yours? |
there is nothing special here, just add the specific version in your package.json and install. (No login needed) |
@SebiVPS Thats is the key difference right there. React had a rather large changelog with 17.0.0. Does anyone know if using '--legacy-peer-deps' flag creates havoc? Update: I was able to archive and create the .ipa file by using the master version in package.json:
I also added:
as per @mfazekas suggestion. So far this works with
|
Same issue |
Fixed by upgrading from |
I did all the above solution with clean installation but I'm getting this error |
I have the same issue |
@ghadeeraqraa1992 Similar thing happend to me out of the blue, you may want to try the following thread: mapbox/mapbox-gl-native-ios#555 Edit: ahhh nevermind, you already found that one |
did you find a solution ? |
Describe the bug
iOS: Xcode 'Archive' produces a corrupt archive. Seems to be possibly related to iOS Mapbox SDK 5.8. Found a workaround, see below.
To Reproduce
npx react-native init RNMapboxTest
cd RNMapboxTest
yarn add @react-native-mapbox-gl/maps
cd ios && pod install
/Library/Developer/Xcode/Archives
, get error 'The archive may be corrupt or unreadable.'Expected behavior
Expecting to be able to build an Archive for App Store submission.
Screenshots
Versions
Possible reason & Workaround
$ReactNativeMapboxGLIOSVersion
to explicitly set the iOS SDK version. However, it seems to apply also to some other dependencies, and if you set it to '~> 5.9.0', @react-native-mapbox-gl-mapbox-static fails to install. However setting it to '~> 5.8' leads to install of Mapbox iOS SDK 5.9.0 and latest 5.X for others. And now archive build works correctly!$ReactNativeMapboxGLIOSVersion = '~> 5.8'
into the Podfile, andpod install
.The text was updated successfully, but these errors were encountered: