chore(ios): remove old architecture code (#4130)

* chore(ios): remove old architecture code

Remove React Native old architecture (Paper/Bridge) code from iOS,
keeping only new architecture (Fabric/TurboModules) code.

Changes:
- Delete all *ViewManager.m and *ViewManager.swift files (old arch view managers)
- Remove #ifdef RCT_NEW_ARCH_ENABLED guards from ComponentView files
- Simplify Module.h files to only conform to TurboModule protocols
- Remove old arch conditionals from Module.mm files
- Update RNMBXViewResolver to remove old arch code paths
- Remove unused RCTViewManager imports from Bridge/RNMBX.h and Swift.pre.h
- Remove guards from RNMBXFabricPropConvert.mm and RNMBXFollyConvert.h

This is a follow-up to the Android old architecture removal (#4128)
and continues the 10.3.0 cleanup work (#4118).

* fix(ios): add __cplusplus guard to ComponentView.h files

The umbrella header is compiled as Objective-C (not Objective-C++),
which causes errors when ComponentView.h files import Fabric headers
that transitively include C++ code like <atomic>.

Use #ifdef __cplusplus guard instead of RCT_NEW_ARCH_ENABLED to:
- Allow content when compiled as Objective-C++ (.mm files)
- Hide content when compiled as Objective-C (umbrella header)

* fix(ios): add module wrapper methods to RNMBXMapView

Move 16 module methods from static RNMBXMapViewManager methods to instance methods on RNMBXMapView, fixing build errors after old architecture removal.

* fix(ios): restructure Module.h files for Swift compilation

Move Foundation/UIKit imports outside __cplusplus guard and provide
plain NSObject interface for non-C++ contexts (Swift).

* fix(ios): add module wrapper methods to RNMBXViewport and RNMBXShapeSource

Call methods directly on view instances instead of through Manager classes.

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: mfazekas

ios/RNMBX/Bridge/RNMBX.h

@@ -1,6 +1,5 @@
 /* Those will be available for Swift */
 #import <React/RCTEventEmitter.h>
-#import <React/RCTViewManager.h>
 #import <React/RCTImageLoaderProtocol.h>
 #import <React/RCTUIManager.h>
 

ios/RNMBX/RNMBXAtmosphereComponentView.h

@@ -1,4 +1,4 @@
-#ifdef RCT_NEW_ARCH_ENABLED
+#ifdef __cplusplus
 
 #import <UIKit/UIKit.h>
 
@@ -11,5 +11,4 @@ NS_ASSUME_NONNULL_BEGIN
 @end
 
 NS_ASSUME_NONNULL_END
-
-#endif // RCT_NEW_ARCH_ENABLED
+#endif // __cplusplus

ios/RNMBX/RNMBXAtmosphereComponentView.mm

@@ -1,4 +1,3 @@
-#ifdef RCT_NEW_ARCH_ENABLED
 
 #import "RNMBXAtmosphereComponentView.h"
 #import "RNMBXFabricHelpers.h"
@@ -79,4 +78,3 @@ - (void)prepareForRecycle
   return RNMBXAtmosphereComponentView.class;
 }
 
-#endif // RCT_NEW_ARCH_ENABLED

ios/RNMBX/RNMBXAtmosphereViewManager.m

@@ -1,4 +1,4 @@
-#ifdef RCT_NEW_ARCH_ENABLED
+#ifdef __cplusplus
 
 #import <UIKit/UIKit.h>
 
@@ -11,5 +11,4 @@ NS_ASSUME_NONNULL_BEGIN
 @end
 
 NS_ASSUME_NONNULL_END
-
-#endif // RCT_NEW_ARCH_ENABLED
+#endif // __cplusplus

ios/RNMBX/RNMBXAtmosphereViewManager.swift

@@ -1,4 +1,3 @@
-#ifdef RCT_NEW_ARCH_ENABLED
 
 #import "RNMBXBackgroundLayerComponentView.h"
 #import "RNMBXFabricHelpers.h"
@@ -74,4 +73,3 @@ - (void)prepareForRecycle
   return RNMBXBackgroundLayerComponentView.class;
 }
 
-#endif // RCT_NEW_ARCH_ENABLED

ios/RNMBX/RNMBXBackgroundLayerComponentView.h

@@ -1,4 +1,4 @@
-#ifdef RCT_NEW_ARCH_ENABLED
+#ifdef __cplusplus
 
 #import <UIKit/UIKit.h>
 
@@ -11,5 +11,4 @@ NS_ASSUME_NONNULL_BEGIN
 @end
 
 NS_ASSUME_NONNULL_END
-
-#endif // RCT_NEW_ARCH_ENABLED
+#endif // __cplusplus