-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation to prevent arguments with both required and default_value #3011
Add validation to prevent arguments with both required and default_value #3011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change 💅 . The rest LGTM.
Co-authored-by: Lairton Lélis <lairtonlelis@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a crack at this! I left a couple of suggestions.
@rmosolgo take a look and let me know if it is ok now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks again for taking care of this!
Sorry @Diego-Thomaz , I made a mistake on this one -- apparently there are cases where default_value: and |
No problem @rmosolgo I was glad to help anyway. |
Close #3001