From 68aeab4823e3c1af2db28ef0c3e3ccce0a811bbb Mon Sep 17 00:00:00 2001 From: mas192 Date: Tue, 21 May 2024 08:47:49 -0700 Subject: [PATCH] removed reserved words restriction for bundle identifier --- tests/commands/new/test_validate_bundle.py | 1 - tests/config/test_AppConfig.py | 4 ---- tests/config/test_is_valid_bundle_identifier.py | 6 ------ 3 files changed, 11 deletions(-) diff --git a/tests/commands/new/test_validate_bundle.py b/tests/commands/new/test_validate_bundle.py index dec8c4b0b..5643acf1b 100644 --- a/tests/commands/new/test_validate_bundle.py +++ b/tests/commands/new/test_validate_bundle.py @@ -27,7 +27,6 @@ def test_valid_bundle(new_command, bundle): "com.hello_world", # underscore "com.hello,world", # comma "com.hello world!", # exclamation point - "com.pass.example", # Reserved word ], ) def test_invalid_bundle(new_command, bundle): diff --git a/tests/config/test_AppConfig.py b/tests/config/test_AppConfig.py index bddd122c7..1595857e6 100644 --- a/tests/config/test_AppConfig.py +++ b/tests/config/test_AppConfig.py @@ -170,10 +170,6 @@ def test_valid_bundle(bundle): "com.hello_world", # underscore "com.hello,world", # comma "com.hello world!", # exclamation point - "com.pass", # Python reserved word - "com.pass.example", # Python reserved word - "com.switch", # Java reserved word - "com.switch.example", # Java reserved word ], ) def test_invalid_bundle_identifier(bundle): diff --git a/tests/config/test_is_valid_bundle_identifier.py b/tests/config/test_is_valid_bundle_identifier.py index bdf832628..d83822670 100644 --- a/tests/config/test_is_valid_bundle_identifier.py +++ b/tests/config/test_is_valid_bundle_identifier.py @@ -28,12 +28,6 @@ def test_valid_bundle(bundle): "com.hello_world", # underscore "com.hello,world", # comma "com.hello world!", # exclamation point - "com.pass", # Python reserved word - "com.pass.example", # Python reserved word - "com.switch", # Java reserved word - "com.switch.example", # Java reserved word - "int.example", # Valid identifier with a reserved word as the TLD - "do.example", # This *should* be valid by the Java spec, but Android chokes. ], ) def test_invalid_bundle(bundle):