Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle Seeding Bug #509

Closed
PavelBlend opened this issue Dec 12, 2020 · 2 comments
Closed

Particle Seeding Bug #509

PavelBlend opened this issue Dec 12, 2020 · 2 comments
Labels

Comments

@PavelBlend
Copy link

System Information

Blender Version (including hash): 2.90.1 3e85bb34d0d7
FLIP Fluids Version: 1.0.9
Operating System: Windows 10 64 bit
CPU: AMD A8 5600K
GFX: -
RAM: 16 GB

Describe the bug

I'm not sure if this is a bug or not. I have done a liquid test with a huge number of substeps (64). I noticed that particles are born too often in some local areas. Perhaps this error is visible even with a lower number of substeps, although this error will not be so noticeable.

To Reproduce

Bake liquid from this file:
particles_seeding_bug.zip

Expected Behaviour

Particles should not be born at such a close distance from each other.

Actual Behaviour

The particles are too close to each other, they are lined up.

Screenshots

particle_bug
seeding_2

@rlguy
Copy link
Owner

rlguy commented Dec 14, 2020

Hi PavelBlend,

Thanks for the report! It looks like this issue is caused by unexpected behavior of the random number generator (RNG) that we are using. The RNG is generating the same 'random' positions for every substep which is creating long lines of particles in some locations.

I have learned that the current RNG technique we are using (C++ rand()) is not good and I have updated the RNG method to a better technique (Mersenne Twister), which should fix this issue:

new_rng

I will leave this issue open for now. I still need to test this on MacOS and Linux to make sure it works. I'll update later when this fix will be available.

@rlguy rlguy added the bug label Dec 14, 2020
@rlguy
Copy link
Owner

rlguy commented Dec 15, 2020

This fix is now available in experimental version 9.0.9.11.

@rlguy rlguy closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants