Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to choose default result window #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patrickwhite256
Copy link

  • Adding g:ag_default_window_type to choose to use the quickfix or
    location list
  • Adding :LAg... variants of commands that did not already have them
  • Adding :QAg... variants of all commands

Previously, it was difficult to use the location list by default, since
something like command -nargs=* Ag LAg <args> in the vimrc would get
overridden by the command! in the plugin.

In my opinion, the variants should eventually be removed, since I don't
really see a reason why someone would want to use one list sometimes but
the other sometimes. If people agree with me:

  • The :LAg... variants should be put on a deprecation path
  • The :QAg... variants should just be removed now

If you agree they should be removed, I'll update the PR to do these things.

- Adding `g:ag_default_window_type` to choose to use the quickfix or
  location list
- Adding `:LAg...` variants of commands that did not already have them
- Adding `:QAg...` variants of all commands

Previously, it was difficult to use the location list by default, since
something like `command -nargs=* Ag LAg <args>` in the vimrc would get
overridden by the `command!` in the plugin.

In my opinion, the variants should eventually be removed, since I don't
really see a reason why someone would want to use one list sometimes but
the other sometimes. If people agree with me:

- The `:LAg...` variants should be put on a deprecation path
- The `:QAg...` variants should just be removed now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant