[WIP] Merge expr and jsast - not for review #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed toAST to return just one ASTWithSourceSpan, and started removing nested constructors from this function. Each call to toAST should construct an ASTWithSourceSpan node and recursively call toAST on its children.
Doesn't build. Removed the Statement and List types. Added Expression and StatementList types. Need to add a Variables type.
This is a WIP. It compiles now, but only because I commented out some things.
Nearly done, just need to sort out leading elisions stuff.
Haven't finished using them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't build. Not for review (but feel free to have a look).
Started merging Expression and JSAST data types into one data type (AST).