Enhancements to Disk Ripping Script and Docker Configuration #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is useful for me to test options on the same disc without re-inserting the disc and for those working with "remote" drives
also a small fix for the Dockerfile
update port to use a port set build to the latest dockerfile comment out optional configuration
Refactor Dockerfile for improved efficiency - Consolidate ENV declarations into a single instruction, reducing image layers and improving readability. - Utilize non-interactive mode and `--no-install-recommends` for apt-get install to minimize unnecessary package installs. - Merge apt-get update, install, autoremove, and cleanup steps into a single RUN instruction to reduce final image size. - Use pip's `--no-cache-dir` option to avoid caching Python packages during installation. - Add an ADD command with /dev/null as the destination to invalidate the Docker build cache upon new releases of MakeMKV without adding files to the image. - Set proper file permissions for initialization scripts in one RUN instruction, avoiding additional layers for each chmod. This optimization results in a Docker image that is more efficient in terms of size and layers, with improved cache invalidation strategy, and is easier to understand and maintain. previous image size was: 748MB current image size is: 673MB
…ling The disc ripper bash script has been refactored to improve readability, maintainability, and consistency. Notable changes include the use of `printf` for startup information, the definition of default configuration values using parameter expansion, and the implementation of a consistent error handling strategy. Revised drive type detection logic uses pattern matching with `DRV:0` patterns, and the `ejectdisc` function now follows a more standardized lowercase function naming convention. This commit aims to enhance the reliability and clarity of the disc ripping process.
alsomakeiso will also make an iso of the disc and do whatever else is meant to be done with the disc this commit also migrates many echo's to a safer printf
this will include the timestamp in the folder path
This reverts commit 6f7c51f.
…later" This reverts commit 5115e90.
match existing formatting
add a `
also use case statements when possible
|
Looks helpful and extensive. Thanks. Will need some testing before the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces significant updates to the docker-ripper project, aiming to enhance the readability and add flexibility to Docker configurations.
Key Changes
DEBUGTOWEBto aid in monitoring and troubleshooting.DEBUGdocker-compose.ymlto include more configuration options with explanations for each and definitions for building the images.Dockerfilefor bothlatestand manual build to optimize space and improve readability.Docker Compose Adjustments
The provided
docker-compose.ymlnow includes configurations that allow users to:EJECTENABLED).JUSTMAKEISOandALSOMAKEISO).latestandmanual-buildoptions) in the compose fileBuilding the Image:
The README now also contains simplified instructions for building and running the project using Docker Compose:
Clone the repository
Navigate to the repo directory
Build the image using
docker compose buildRun the container using
docker compose up -dAsks
Updates
2024-01-27 - Changed to Draft, investigating use of chmod, testing