Skip to content

Commit 8369312

Browse files
shipilevpull[bot]
authored andcommitted
8315942: Sort platform enums and definitions after JDK-8304913 follow-ups
Reviewed-by: rriggs, jpai
1 parent ec670c8 commit 8369312

File tree

3 files changed

+18
-17
lines changed

3 files changed

+18
-17
lines changed

src/java.base/share/classes/jdk/internal/util/Architecture.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,20 +41,20 @@ public enum Architecture {
4141
* An unknown architecture not specifically named.
4242
* The addrSize and ByteOrder values are those of the current architecture.
4343
*/
44-
OTHER(is64bit() ? 64 : 32, ByteOrder.nativeOrder()),
45-
X64(64, ByteOrder.LITTLE_ENDIAN), // Represents AMD64 and X86_64
46-
X86(32, ByteOrder.LITTLE_ENDIAN),
4744
AARCH64(64, ByteOrder.LITTLE_ENDIAN),
4845
ARM(32, ByteOrder.LITTLE_ENDIAN),
49-
RISCV64(64, ByteOrder.LITTLE_ENDIAN),
5046
LOONGARCH64(64, ByteOrder.LITTLE_ENDIAN),
51-
S390(64, ByteOrder.BIG_ENDIAN),
47+
MIPSEL(32, ByteOrder.LITTLE_ENDIAN),
48+
MIPS64EL(64, ByteOrder.LITTLE_ENDIAN),
49+
OTHER(is64bit() ? 64 : 32, ByteOrder.nativeOrder()),
5250
PPC(32, ByteOrder.BIG_ENDIAN),
5351
PPC64(64, ByteOrder.BIG_ENDIAN),
5452
PPC64LE(64, ByteOrder.LITTLE_ENDIAN),
55-
MIPSEL(32, ByteOrder.LITTLE_ENDIAN),
56-
MIPS64EL(64, ByteOrder.LITTLE_ENDIAN),
53+
RISCV64(64, ByteOrder.LITTLE_ENDIAN),
54+
S390(64, ByteOrder.BIG_ENDIAN),
5755
SPARCV9(64, ByteOrder.BIG_ENDIAN),
56+
X86(32, ByteOrder.LITTLE_ENDIAN),
57+
X64(64, ByteOrder.LITTLE_ENDIAN), // Represents AMD64 and X86_64
5858
;
5959

6060
private final int addrSize;

src/java.base/share/classes/jdk/internal/util/PlatformProps.java.template

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,18 @@ class PlatformProps {
5252
// Precomputed booleans for each Architecture, shared with jdk.internal.util.Architecture
5353
// The variables are named to match the Architecture value names, and
5454
// the values chosen to match the build values.
55-
static final boolean TARGET_ARCH_IS_X64 = "@@OPENJDK_TARGET_CPU@@" == "x64";
56-
static final boolean TARGET_ARCH_IS_X86 = "@@OPENJDK_TARGET_CPU@@" == "x86";
5755
static final boolean TARGET_ARCH_IS_AARCH64 = "@@OPENJDK_TARGET_CPU@@" == "aarch64";
5856
static final boolean TARGET_ARCH_IS_ARM = "@@OPENJDK_TARGET_CPU@@" == "arm";
59-
static final boolean TARGET_ARCH_IS_RISCV64 = "@@OPENJDK_TARGET_CPU@@" == "riscv64";
6057
static final boolean TARGET_ARCH_IS_LOONGARCH64 = "@@OPENJDK_TARGET_CPU@@" == "loongarch64";
61-
static final boolean TARGET_ARCH_IS_S390 = "@@OPENJDK_TARGET_CPU@@" == "s390";
58+
static final boolean TARGET_ARCH_IS_MIPSEL = "@@OPENJDK_TARGET_CPU@@" == "mipsel";
59+
static final boolean TARGET_ARCH_IS_MIPS64EL= "@@OPENJDK_TARGET_CPU@@" == "mips64el";
6260
static final boolean TARGET_ARCH_IS_PPC = "@@OPENJDK_TARGET_CPU@@" == "ppc";
6361
static final boolean TARGET_ARCH_IS_PPC64 = "@@OPENJDK_TARGET_CPU@@" == "ppc64";
6462
static final boolean TARGET_ARCH_IS_PPC64LE = "@@OPENJDK_TARGET_CPU@@" == "ppc64le";
65-
static final boolean TARGET_ARCH_IS_MIPSEL = "@@OPENJDK_TARGET_CPU@@" == "mipsel";
66-
static final boolean TARGET_ARCH_IS_MIPS64EL= "@@OPENJDK_TARGET_CPU@@" == "mips64el";
63+
static final boolean TARGET_ARCH_IS_RISCV64 = "@@OPENJDK_TARGET_CPU@@" == "riscv64";
64+
static final boolean TARGET_ARCH_IS_S390 = "@@OPENJDK_TARGET_CPU@@" == "s390";
6765
static final boolean TARGET_ARCH_IS_SPARCV9 = "@@OPENJDK_TARGET_CPU@@" == "sparcv9";
66+
static final boolean TARGET_ARCH_IS_X86 = "@@OPENJDK_TARGET_CPU@@" == "x86";
67+
static final boolean TARGET_ARCH_IS_X64 = "@@OPENJDK_TARGET_CPU@@" == "x64";
68+
6869
}

test/jdk/jdk/internal/util/ArchTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,17 @@
3030

3131
import static jdk.internal.util.Architecture.AARCH64;
3232
import static jdk.internal.util.Architecture.ARM;
33+
import static jdk.internal.util.Architecture.LOONGARCH64;
34+
import static jdk.internal.util.Architecture.MIPSEL;
35+
import static jdk.internal.util.Architecture.MIPS64EL;
3336
import static jdk.internal.util.Architecture.PPC;
3437
import static jdk.internal.util.Architecture.PPC64;
3538
import static jdk.internal.util.Architecture.PPC64LE;
3639
import static jdk.internal.util.Architecture.RISCV64;
37-
import static jdk.internal.util.Architecture.LOONGARCH64;
3840
import static jdk.internal.util.Architecture.S390;
41+
import static jdk.internal.util.Architecture.SPARCV9;
3942
import static jdk.internal.util.Architecture.X64;
4043
import static jdk.internal.util.Architecture.X86;
41-
import static jdk.internal.util.Architecture.MIPSEL;
42-
import static jdk.internal.util.Architecture.MIPS64EL;
43-
import static jdk.internal.util.Architecture.SPARCV9;
4444

4545
import org.junit.jupiter.api.Test;
4646
import org.junit.jupiter.params.ParameterizedTest;

0 commit comments

Comments
 (0)