Skip to content

Commit 0183ebc

Browse files
committed
chore(release): update version to 2.0.24-rc.1
1 parent 546f5d4 commit 0183ebc

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.github/workflows/release.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ jobs:
5151

5252
- name: Setup
5353
env:
54+
# https://docs.github.com/en/actions/security-guides/automatic-token-authentication
5455
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5556
R2_RELEASES_ACCESS_KEY_ID: ${{ secrets.R2_RELEASES_ACCESS_KEY_ID }}
5657
R2_RELEASES_SECRET_ACCESS_KEY: ${{ secrets.R2_RELEASES_SECRET_ACCESS_KEY }}
@@ -259,6 +260,7 @@ jobs:
259260

260261
- name: Complete
261262
env:
263+
# https://cli.github.com/manual/gh_help_environment
262264
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
263265
R2_RELEASES_ACCESS_KEY_ID: ${{ secrets.R2_RELEASES_ACCESS_KEY_ID }}
264266
R2_RELEASES_SECRET_ACCESS_KEY: ${{ secrets.R2_RELEASES_SECRET_ACCESS_KEY }}

scripts/release/artifacts.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ export async function updateArtifacts(opts: ReleaseOpts) {
1414
let awsAccessKeyId = process.env.R2_RELEASES_ACCESS_KEY_ID;
1515
if (!awsAccessKeyId) {
1616
const result =
17-
await $`op read ${"op://Engineering/rivet-releases R2 Upload/username"}`;
17+
await $`op read "op://Engineering/rivet-releases R2 Upload/username"`;
1818
awsAccessKeyId = result.stdout.trim();
1919
}
2020
let awsSecretAccessKey = process.env.R2_RELEASES_SECRET_ACCESS_KEY;
2121
if (!awsSecretAccessKey) {
2222
const result =
23-
await $`op read ${"op://Engineering/rivet-releases R2 Upload/password"}`;
23+
await $`op read "op://Engineering/rivet-releases R2 Upload/password"`;
2424
awsSecretAccessKey = result.stdout.trim();
2525
}
2626

scripts/release/main.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,13 @@ async function validateReuseVersion(version: string): Promise<void> {
101101
let awsAccessKeyId = process.env.R2_RELEASES_ACCESS_KEY_ID;
102102
if (!awsAccessKeyId) {
103103
const result =
104-
await $`op read ${"op://Engineering/rivet-releases R2 Upload/username"}`;
104+
await $`op read "op://Engineering/rivet-releases R2 Upload/username"`;
105105
awsAccessKeyId = result.stdout.trim();
106106
}
107107
let awsSecretAccessKey = process.env.R2_RELEASES_SECRET_ACCESS_KEY;
108108
if (!awsSecretAccessKey) {
109109
const result =
110-
await $`op read ${"op://Engineering/rivet-releases R2 Upload/password"}`;
110+
await $`op read "op://Engineering/rivet-releases R2 Upload/password"`;
111111
awsSecretAccessKey = result.stdout.trim();
112112
}
113113

0 commit comments

Comments
 (0)