fix: use the constructor function every time a periodic job is scheduled, instead of when its registered #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elee1766
changed the title
elee1766
changed the title
|
Oops, yes, thanks! I'll try to add a test case to verify this. |
brandur
approved these changes
Jul 4, 2024
brandur
added a commit
that referenced
this pull request
Jul 4, 2024
We haven't cut a new release in a while, and the bug in #420 is kind of bad, so now that there's a fix it's not a bad time to cut a new release. I'm also including a test case that catches the bug from #420. Apparently none of our other test cases can catch the problem, so it's good to have a regression guard.
brandur
added a commit
that referenced
this pull request
Jul 4, 2024
We haven't cut a new release in a while, and the bug in #420 is kind of bad, so now that there's a fix it's not a bad time to cut a new release. I'm also including a test case that catches the bug from #420. Apparently none of our other test cases can catch the problem, so it's good to have a regression guard.
brandur
added a commit
that referenced
this pull request
Jul 4, 2024
We haven't cut a new release in a while, and the bug in #420 is kind of bad, so now that there's a fix it's not a bad time to cut a new release. I'm also including a test case that catches the bug from #420. Apparently none of our other test cases can catch the problem, so it's good to have a regression guard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now, the constructor gets called when converting to an internal job, which causes the constructor to use the value at add time.
however, the comments say
so im assuming this is whats intended?