Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customizable MaxAttempts default value #383

Merged
merged 1 commit into from
Jun 5, 2024
Merged

customizable MaxAttempts default value #383

merged 1 commit into from
Jun 5, 2024

Conversation

bgentry
Copy link
Contributor

@bgentry bgentry commented Jun 4, 2024

This adds a MaxAttempts setting to Config to enable the default max attempts to be customized (instead of the global default MaxAttemptsDefault of 25).

Fixes #381.

@bgentry bgentry added the enhancement New feature or request label Jun 4, 2024
@bgentry bgentry requested a review from brandur June 4, 2024 18:18
@bgentry bgentry mentioned this pull request Jun 4, 2024
Closed
@bgentry
customizable MaxAttempts default value
dcc0360 
This adds a `MaxAttempts` setting to `Config` to enable the default max
attempts to be customized (instead of the global default
`MaxAttemptsDefault` of 25).

Fixes #381.
@bgentry bgentry force-pushed the bg-client-level-max-attempts-default branch from 882cc5b to dcc0360 Compare June 4, 2024 18:22
brandur
brandur approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@brandur brandur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wicked, LGTM.

@bgentry bgentry merged commit edb42d2 into master Jun 5, 2024
10 checks passed
@bgentry bgentry deleted the bg-client-level-max-attempts-default branch June 5, 2024 04:34
@bgentry bgentry mentioned this pull request Jun 13, 2024
Merged
bgentry added a commit that referenced this pull request Jun 13, 2024
@bgentry
Prepare version 0.7.0
e36d135 
Prepare version 0.7.0 for release. This includes the bugfix from #376
(allow `StopAndCancel` to be called when a `Stop` is already ongoing),
and new features from #383 (allow customizing default `MaxAttempts` at
the client level) and #390 (`JobDelete` + `JobDeleteTx` APIs).
bgentry added a commit that referenced this pull request Jun 14, 2024
@bgentry
Prepare version 0.7.0 (#394)
c1aa4ee 
Prepare version 0.7.0 for release. This includes the bugfix from #376
(allow `StopAndCancel` to be called when a `Stop` is already ongoing),
and new features from #383 (allow customizing default `MaxAttempts` at
the client level) and #390 (`JobDelete` + `JobDeleteTx` APIs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandur brandur brandur approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change default retry count
2 participants
@bgentry @brandur