Replaced 'LameException' with meaningful exception names

Author: Hugo Bonacci

Bson/BsonObject.cs

@@ -478,12 +478,10 @@ private static byte[] _BinarySerialize<T>(T value) where T : class {
                 }
             }
             //notify if they cannot serialize this object
-            catch (SerializationException ex) {
-                throw new LameException("Not allowed to seralize");
-            }
-            //notify for other unexpected errors
             catch (Exception ex) {
-                throw new LameException("Failed to serialize object");
+                throw new MongoSerializationException(
+                    value == null ? "null" : value.GetType().Name, 
+                    ex);
             }
 
         }
@@ -498,9 +496,9 @@ private static object _BinaryDeserialize(byte[] bytes) {
                     return formatter.Deserialize(input);
                 }
             }
-            //notify for other unexpected errors
+            //notify if they cannot serialize this object
             catch (Exception ex) {
-                throw new LameException("Failed to serialize object");
+                throw new MongoDeserializationException(ex);
             }
 
         }

Commands/MongoDatabaseCommands.cs

@@ -41,7 +41,7 @@ public static MethodResult Authenticate(MongoDatabase database, string username,
             //get the values required
             GetNonceResult nonce = MongoDatabaseCommands.GetNonce(database);
             if (!nonce.HasNonce) {
-                throw new LameException("Missing nonce from database!");
+                throw new MongoServerException(string.Format("Unable to get a nonce value from {0}.", database.Connection.Host));
             }
 
             //issue the actual command
@@ -375,8 +375,12 @@ public static CommandResponse RunCommand(MongoDatabase database, BsonObject para
 
             //send the command and check for the result
             CommandResponse response = database.SendRequest(request) as CommandResponse;
-            if (response == null) {
-                throw new LameException("Invoking command failed to return a response!");
+            if (response == null && expectResponse) {
+                throw new MongoServerException(
+                    string.Format(
+                        "The request to {0} expected a response but nothing was returned!", 
+                        database.Connection.Host
+                        ));
             }
 
             //return any documents that were found

DataTypes/MongoDataType.cs

@@ -127,7 +127,7 @@ public static void RegisterMongoDataType<T>() where T : MongoDataType {
 
             //make sure this isn't already added
             if (MongoDataType.IsTypeRegistered<T>()) {
-                throw new LameException("This type is already in here");
+                throw new MongoTypeAlreadyRegisteredException(typeof(T));
             }
 
             //add the instance

Exceptions/LameException.cs

@@ -47,7 +47,14 @@
   </ItemGroup>
   <ItemGroup>
     <Compile Include="Bson\BsonAnonymousTypeParser.cs" />
+    <Compile Include="Exceptions\ConnectionNotOpenedException.cs" />
+    <Compile Include="Exceptions\InvalidMongoConnectionStringException.cs" />
+    <Compile Include="Exceptions\MissingCollectionNameException.cs" />
+    <Compile Include="Exceptions\MongoTypeAlreadyRegisteredException.cs" />
+    <Compile Include="Exceptions\MongoDeserializationException.cs" />
+    <Compile Include="Exceptions\MongoSerializationException.cs" />
     <Compile Include="Exceptions\MongoServerException.cs" />
+    <Compile Include="Exceptions\NoCursorsFoundException.cs" />
     <Compile Include="Extensions\Queries\MongoQueryExtensions.cs" />
     <Compile Include="MongoAdminDatabase.cs" />
     <Compile Include="Bson\BsonCollection.cs" />
@@ -76,7 +83,6 @@
     <Compile Include="DataTypes\MongoObjectType.cs" />
     <Compile Include="DataTypes\MongoOidType.cs" />
     <Compile Include="DataTypes\MongoStringType.cs" />
-    <Compile Include="Exceptions\LameException.cs" />
     <Compile Include="Extensions\EnumerationExtensions.cs" />
     <Compile Include="Helpers\Helpers.cs" />
     <Compile Include="MongoCollection.cs" />

Mongo.csproj

@@ -158,7 +158,7 @@ public ResponseBase SendRequest(RequestBase request) {
 
                 //perform normal checking
                 if (!this.Connected) {
-                    throw new LameException("Connection isn't open yet!");
+                    throw new ConnectionNotOpenedException("Connection isn't open yet!");
                 }
 
                 //send the header first

MongoConnection.cs

@@ -83,7 +83,7 @@ public void ParseString(string connectionString) {
                 }
             }
             catch {
-                throw new LameException("Couldn't use the connection string.");
+                throw new InvalidMongoConnectionStringException();
             }
         }
 

MongoConnectionString.cs

@@ -431,7 +431,7 @@ public MongoCollection GetCollection(string collection) {
             //verify the name is okay
             collection = (collection ?? string.Empty).Trim();
             if (string.IsNullOrEmpty(collection)) {
-                throw new LameException("A collection must have a name!");
+                throw new MissingCollectionNameException("collection");
             }
 
             //check if this is already loaded
@@ -492,7 +492,7 @@ public MongoCursor GetLastCursor() {
 
             //if there aren't any cursors throw an error
             if (this._Cursors.Count == 0) {
-                throw new LameException("No cursors were found!");
+                throw new NoCursorsFoundException();
             }
 
             //return the most recently added item
@@ -527,7 +527,7 @@ public IEnumerable<MongoDocument> GetMore(MongoCursor cursor, int count) {
 
             //make sure this is really a cursor
             if (cursor == null) {
-                throw new LameException("This isn't a cursor!");
+                throw new ArgumentNullException("cursor", "You must provide a cursor to use.");
             }
 
             //start with the cursor value
@@ -567,7 +567,7 @@ public IEnumerable<MongoDocument> GetMore(MongoCursor cursor, int count) {
 
             //make sure something was found
             if (response == null) {
-                throw new LameException("Failed to get more records!");
+                throw new MongoServerException("GetMore expected a response but nothing was returned from the server.");
             }
 
             //return the found documents

MongoDatabase.cs

@@ -106,8 +106,8 @@ public void GenerateId() {
         public MongoOid Id {
             get { return this.Get<MongoOid>(Mongo.DocumentIdKey); }
             set {
-                if (value == null && !(value is MongoOid)) {
-                    throw new LameException("Must be an Oid type!");
+                if (value != null && !(value is MongoOid)) {
+                    throw new ArgumentException("You can only assign a MongoOid as the Id for a MongoDocument");
                 }
                 this.Set<MongoOid>(Mongo.DocumentIdKey, value); 
             }

MongoDocument.cs

@@ -90,7 +90,7 @@ public void SetId(string value) {
 
             //verify the length
             if (value.Length != 24) {
-                throw new LameException("Must be 24 characters... yeah...");
+                throw new ArgumentException("The provided ID was not in an expected format.", "value");
             }
 
             //parse every pair of bytes