Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: refactor executors to split chunks using DataChunkBuilder #348

Closed
6 tasks done
Tracked by #317
TennyZhuang opened this issue Jan 21, 2022 · 5 comments
Closed
6 tasks done
Tracked by #317

executor: refactor executors to split chunks using DataChunkBuilder #348

TennyZhuang opened this issue Jan 21, 2022 · 5 comments
Labels
good first issue Good for newcomers

Comments

@TennyZhuang
Copy link
Collaborator

TennyZhuang commented Jan 21, 2022 •
edited by skyzh
Loading

This was referenced Jan 21, 2022
Closed
Merged
@skyzh skyzh changed the title Refactor executors to split chunks executor: refactor executors to split chunks Jan 23, 2022
@wangrunji0408 wangrunji0408 mentioned this issue Jan 23, 2022
Merged
@skyzh skyzh added the good first issue Good for newcomers label Jan 29, 2022
@skyzh
Copy link
Member

skyzh commented Jan 29, 2022

Refactoring executors to split chunk seems like a good-first-issue. If you are interested in refactoring one of our executors, feel free to create a tracking issue!

@TennyZhuang TennyZhuang mentioned this issue Feb 14, 2022
Closed
@wangqiim
Copy link
Contributor

wangqiim commented Apr 4, 2022

I think it don't need introduce DataChunkBuilder to TopN. Is it right?

@skyzh
Copy link
Member

skyzh commented Apr 6, 2022

I think we need to. TopN might produce very large chunk (e.g., offset 0 limit 10000). It's better to get it chunked, so as to make the parent executor easier to handle.

@skyzh
Copy link
Member

skyzh commented Apr 6, 2022

I've created an issue for that.

@skyzh skyzh changed the title executor: refactor executors to split chunks executor: refactor executors to split chunks using DataChunkBuilder Apr 11, 2022
@xxchan
Copy link
Member

xxchan commented Apr 24, 2022

All done!

@xxchan xxchan closed this as completed Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@skyzh @TennyZhuang @xxchan @wangqiim