Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that page titles in social previews use same duplicate name logic as meta titles #138

Open
eric-schneider opened this issue May 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working quick win

Comments

@eric-schneider
Copy link
Contributor

eric-schneider commented May 30, 2024

As part of #109, we updated the way page meta titles were constructed to avoid duplicate names appearing in the titles. However, it looks like we might not have applied the same logic to the titles used in social previews:

image

Update

@ErickRamirezDS reported (DOC-4578) that the social preview titles for any of the pages in planning-docs are always suffixed with:

Apache Cassandra Capacity Planning Guide

regardless of whether the page is for C*, DSE or HCD.

slack-preview-planning-page

These guides have a different component title for each version in antora.yml. So if Antora only surfaces the title of the "latest" version in the UI model, then we might be limited in what we can do. But we should still investigate to confirm. If we're blocked by Antora, then we might need to consider changing the titles to be more generic and rely on the version switcher to fully communicate to the user which guide they're looking at. Note: this also affects the CQL docs, and any other docset that uses the component version aggregator extension in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quick win
Projects
None yet
Development

No branches or pull requests

2 participants