Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all attributes of TextStyle optional #11

Open
Aran-Fey opened this issue May 12, 2024 · 2 comments
Open

Make all attributes of TextStyle optional #11

Aran-Fey opened this issue May 12, 2024 · 2 comments
Labels
bug Something isn't working enhancement Improves on existing functionality - NOT a new feature

Comments

@Aran-Fey
Copy link
Contributor

Some attributes of TextStyle default to None, which means "unchanged" (i.e. inherit the value from the theme or whatever), but all attributes should do this. This is a tricky change because it affects quite a few different parts of rio, including:

  • Theme
  • getTextDimensions (extra tricky because it removes the element from its parent)
@Aran-Fey Aran-Fey added bug Something isn't working enhancement labels May 12, 2024
@Aran-Fey
Copy link
Contributor Author

This is actually currently bugged because the font is already optional, and getTextDimensions doesn't handle that case correctly.

@mad-moo mad-moo added enhancement Improves on existing functionality - NOT a new feature and removed enhancement labels Jun 11, 2024
@mad-moo
Copy link
Contributor

mad-moo commented Aug 11, 2024

Duplicate of #59?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improves on existing functionality - NOT a new feature
Projects
None yet
Development

No branches or pull requests

2 participants