fix half-way commit text #767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@groverlynn Please squash your commits. |
@WhiredPlanck Just did |
groverlynn
force-pushed
the
commit_text
branch
from
bd450af
to
5f2df89
Compare
groverlynn
force-pushed
the
commit_text
branch
from
5f2df89
to
50d333a
Compare
… (rime#768) follow the default split behavior of boost::split
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
Fix a bug when toggle ascii mode by
commit_textwhile the input segment of the selected candidate is shorter than the complete input (i.e. there are unsegmented raw input beyond the current segment of selected candidate), nothing gets committed at all.Unit test
Manual test
Code Review
Additional Info