Skip to content

Commit d235328

Browse files
committed
Properly handle errors in the regular expressions
1 parent 5dadf38 commit d235328

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

codewalk.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,13 +204,19 @@ func GenerateCodewalk(src string, dst string, basedir string) error {
204204
curr.codewalk.file = lex.Rest()
205205

206206
case "start":
207-
err = curr.codewalk.setStart(regexp.MustCompile(lex.Rest()))
207+
re, err := regexp.Compile(lex.Rest())
208+
if err == nil {
209+
err = curr.codewalk.setStart(re)
210+
}
208211
if err != nil {
209212
return fmt.Errorf("%s:%d: %s", src, lineno, err)
210213
}
211214

212215
case "end":
213-
err = curr.codewalk.setEnd(regexp.MustCompile(lex.Rest()))
216+
re, err := regexp.Compile(lex.Rest())
217+
if err == nil {
218+
err = curr.codewalk.setEnd(re)
219+
}
214220
if err != nil {
215221
return fmt.Errorf("%s:%d: %s", src, lineno, err)
216222
}

0 commit comments

Comments
 (0)