From d6f87354fa26b97dc95814afd410382d5cb6a5c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20Egelund-M=C3=BCller?= Date: Thu, 31 Oct 2024 14:54:45 +0000 Subject: [PATCH] Fix ClickHouse timestamp format for comparison offsets (#6004) --- runtime/drivers/olap.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/drivers/olap.go b/runtime/drivers/olap.go index df74c21430d..0bfa53ded69 100644 --- a/runtime/drivers/olap.go +++ b/runtime/drivers/olap.go @@ -465,7 +465,7 @@ func (d Dialect) DateDiff(grain runtimev1.TimeGrain, t1, t2 time.Time) (string, unit := d.ConvertToDateTruncSpecifier(grain) switch d { case DialectClickHouse: - return fmt.Sprintf("DATEDIFF('%s', TIMESTAMP '%s', TIMESTAMP '%s')", unit, t1.Format(time.RFC3339), t2.Format(time.RFC3339)), nil + return fmt.Sprintf("DATEDIFF('%s', parseDateTimeBestEffort('%s'), parseDateTimeBestEffort('%s'))", unit, t1.Format(time.RFC3339), t2.Format(time.RFC3339)), nil case DialectDruid: return fmt.Sprintf("TIMESTAMPDIFF(%q, TIME_PARSE('%s'), TIME_PARSE('%s'))", unit, t1.Format(time.RFC3339), t2.Format(time.RFC3339)), nil case DialectDuckDB: