thinkdigitalsoftware-namespace-fix #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in namespace.dart. Bring the code up to pedantic.dart standards.
| // upon error, short-circuit | ||
| if (err) return fn(err); | ||
|
|
||
| // if no middleware left, summon callback | ||
| if (!fns[idx + 1]) return fn(null); | ||
| if (fns.length < index + 1) return fn(null); |
There was a problem hiding this comment.
Please verify that this still doesn't what's intended
| /// | ||
| /// TODO: Fix this description or code. Add type parameters to [fn([_])] | ||
| /// | ||
| Namespace clients(fn([_])) { |
There was a problem hiding this comment.
@jumperchen Referenced in issue #14. Please follow up on that before merging this PR
|
@ThinkDigitalSoftware Thanks for the contribution. |
|
You're welcome!
…On Tue, Dec 24, 2019, 6:02 PM Jumper Chen ***@***.***> wrote:
@ThinkDigitalSoftware <https://github.com/ThinkDigitalSoftware> Thanks
for the contribution.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15?email_source=notifications&email_token=AFPYO7NX4WZC4P2WWHEJQCTQ2K5J5A5CNFSM4J4TELV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHTYL7A#issuecomment-568821244>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFPYO7LBB4PBAQL325Y2MZLQ2K5J5ANCNFSM4J4TELVQ>
.
|
jumperchen
added a commit
that referenced
this pull request
Dec 27, 2019
jumperchen
added a commit
that referenced
this pull request
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add links to github repo in pubspec.yaml
Bring namespace.dart up to pedantic standards and add types where I could
to make it easier to understand what parameters were required.