Skip to content

fix #287 for events emitted by the Manager #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jumperchen merged 1 commit into from
Jan 9, 2023
Merged

fix #287 for events emitted by the Manager #313

jumperchen merged 1 commit into from
Jan 9, 2023

Conversation

@Astray-git
Copy link
Contributor

@Astray-git Astray-git commented Jan 6, 2023

As per socket.io docs, some events should be acess on the Manager instance (the io property of the socket).

@Astray-git Astray-git changed the title fix rikulo#287 for events emitted by the Manager fix #287 for events emitted by the Manager Jan 6, 2023
@jumperchen
Copy link
Member

jumperchen commented Jan 9, 2023

Thanks for the contribution.

@jumperchen jumperchen merged commit 163e518 into rikulo:master Jan 9, 2023
@jeiea jeiea mentioned this pull request Jan 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Astray-git @jumperchen