Fix: Better error messages for references to undefined memory locations#1304
Draft
Fix: Better error messages for references to undefined memory locations#1304
Conversation
kalzoo
requested changes
Mar 11, 2021
| if k.name not in patch_values: | ||
| raise KeyError(f"{k.name} is not one of the valid memory descriptors: {patch_values.keys()}") | ||
| if k.index >= len(patch_values[k.name]): | ||
| raise IndexError(f"{k.name} has more parameter values ({k.index}) than expected ({len(patch[k.name])})") |
Contributor
There was a problem hiding this comment.
Is len(patch[k.name]) supposed to be len(patch_values[k.name])?
On that note, it could be worth adding a simple test case. Even with 3.x in the works, 2.x will be in use for a long tail
Contributor
|
@notmgsk Are you still interested in having this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a better error message when
qc.run(binary, memory_map=...)includes:Checklist
flake8conventions.