Skip to content

Commit a2d45f3

Browse files
authored
Merge pull request #363 from nicoklaus/master
fix: install gitlab-runner-helper-packages if version is specified
2 parents 3bcfd4c + a08da17 commit a2d45f3

File tree

2 files changed

+20
-7
lines changed

2 files changed

+20
-7
lines changed

defaults/main.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
---
22
# for versions >= 10.x
33
gitlab_runner_package_name: gitlab-runner
4+
gitlab_runner_helper_package_name: gitlab-runner-helper-images
45

56
gitlab_runner_system_mode: true
67

tasks/install-debian.yml

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@
1919
become: true
2020
when: gitlab_runner_skip_package_repo_install is not defined or not gitlab_runner_skip_package_repo_install
2121

22-
- name: (Debian) Update gitlab_runner_package_name
22+
- name: (Debian) Update gitlab_runner_package_name and gitlab_runner_helper_package_name
2323
ansible.builtin.set_fact:
2424
gitlab_runner_package: "{{ gitlab_runner_package_name }}={{ gitlab_runner_package_version }}"
25+
gitlab_runner_helper_package: "{{ gitlab_runner_helper_package_name }}={{ gitlab_runner_package_version }}"
2526
gitlab_runner_package_state: present
2627
when: gitlab_runner_package_version is defined
2728

@@ -42,16 +43,21 @@
4243
selection: install
4344
when: "'gitlab-runner' in ansible_facts.packages"
4445

45-
- name: (Debian) Install GitLab Runner
46+
- name: (Debian) Unhold GitLab Runner Helper version
47+
changed_when: false
48+
ansible.builtin.dpkg_selections:
49+
name: "{{ gitlab_runner_helper_package_name }}"
50+
selection: install
51+
when: "'gitlab-runner-helper-images' in ansible_facts.packages"
52+
53+
- name: (Debian) Install GitLab Runner Helpers
4654
ansible.builtin.apt:
47-
name: "{{ gitlab_runner_package }}"
55+
name: "{{ gitlab_runner_helper_package }}"
4856
state: "{{ gitlab_runner_package_state }}"
4957
allow_change_held_packages: true
5058
allow_downgrade: true
5159
become: true
52-
environment:
53-
GITLAB_RUNNER_DISABLE_SKEL: "true"
54-
when: ansible_distribution_release in ["buster", "focal", "jammy"]
60+
when: gitlab_runner_package_version is defined
5561

5662
- name: (Debian) Install GitLab Runner
5763
ansible.builtin.apt:
@@ -60,7 +66,6 @@
6066
allow_change_held_packages: true
6167
allow_downgrade: true
6268
become: true
63-
when: ansible_distribution_release not in ["buster", "focal", "jammy"]
6469

6570
- name: (Debian) Hold GitLab Runner version
6671
ansible.builtin.dpkg_selections:
@@ -69,6 +74,13 @@
6974
when: gitlab_runner_package_version is defined
7075
changed_when: false
7176

77+
- name: (Debian) Hold GitLab Runner Helpers version
78+
ansible.builtin.dpkg_selections:
79+
name: "{{ gitlab_runner_helper_package_name }}"
80+
selection: hold
81+
when: gitlab_runner_package_version is defined
82+
changed_when: false
83+
7284
- name: (Debian) Remove ~/gitlab-runner/.bash_logout on debian buster and ubuntu focal
7385
ansible.builtin.file:
7486
path: /home/gitlab-runner/.bash_logout

0 commit comments

Comments
 (0)