Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses humane-test-output to pretty print test outputs #790

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

mcorbin
Copy link
Contributor

@mcorbin mcorbin commented Mar 21, 2017

I just discovered humane-test-output.
Before using it :

FAIL in (foo-test) (riemann.config:25)
expected: (= (:foo result) [{:host "localhost", :service "foo1", :metric 10}])
  actual: (not (= [{:host "localhost", :service "foo", :metric 10}] [{:host "localhost", :service "foo1", :metric 10}]))

after :

FAIL in (foo-test) (riemann.config:25)
expected: [{:host "localhost", :service "foo", :metric 10}]
  actual: [{:host "localhost", :service "foo1", :metric 10}]
    diff: - [{:service "foo"}]
          + [{:service "foo1"}]

this PR fix #787.

@jamtur01
Copy link
Member

LGTM

@jamtur01 jamtur01 merged commit 8bf6b64 into riemann:master Mar 22, 2017
@jamtur01
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretty print test output
2 participants