Remove deprecated TraCI API and switch to libsumo/libtraci#390
Draft
AshFungor wants to merge 6 commits intoriebl:masterfrom
Draft
Remove deprecated TraCI API and switch to libsumo/libtraci#390AshFungor wants to merge 6 commits intoriebl:masterfrom
AshFungor wants to merge 6 commits intoriebl:masterfrom
Conversation
riebl
reviewed
Nov 5, 2025
Owner
riebl
left a comment
riebl
left a comment
There was a problem hiding this comment.
I think the tools/testing stuff should be a separate PR because it is not directly related to the libtraci switch.
| # to the existing SUMO instance is only possible with slower libtraci API. | ||
| # Switching both options to OFF disables SUMO integration. | ||
| option(WITH_LIBTRACI "Build Artery with SUMO support via libtraci" ON) | ||
| option(WITH_LIBSUMO "Build Artery with SUMO support via libsumo" OFF) |
Collaborator
Author
There was a problem hiding this comment.
Only one of those should be set at once :)
AshFungor
force-pushed
the
swicth-to-libsumo
branch
from
291bf6f to
9361351
Compare
Collaborator
Author
|
Hey, @riebl! I wanted to discuss the cpp looks a little. I know you don't like identing namespaces, but how about base classes? I'm used to this class A
: public B,
, public C {
/* contents */
};Which currently formats as class A : public B, public C {
};The first one looks cleaner I guess |
Collaborator
Author
|
Also, I've looked into variable cache - it seems still useful (even with libsumo), but I've switched to more template-heavy implementation. Can you have a look? Keep in mind, I have not even compiled it yet, so I wish you could just give your overall impression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial PR for requested and awaited switch. There's still much more work to do here, I'll post it so others may track progress.