split up :modulecheck-core into -finding and -rule modules

Author: RBusarow

artifacts.json

@@ -55,6 +55,30 @@
     "packaging": "jar",
     "javaVersion": "11"
   },
+  {
+    "gradlePath": ":modulecheck-finding:impl",
+    "group": "com.rickbusarow.modulecheck",
+    "artifactId": "modulecheck-finding-impl",
+    "description": "Fast dependency graph linting for Gradle projects",
+    "packaging": "jar",
+    "javaVersion": "11"
+  },
+  {
+    "gradlePath": ":modulecheck-finding:impl-android",
+    "group": "com.rickbusarow.modulecheck",
+    "artifactId": "modulecheck-finding-impl-android",
+    "description": "Fast dependency graph linting for Gradle projects",
+    "packaging": "jar",
+    "javaVersion": "11"
+  },
+  {
+    "gradlePath": ":modulecheck-finding:impl-sort",
+    "group": "com.rickbusarow.modulecheck",
+    "artifactId": "modulecheck-finding-impl-sort",
+    "description": "Fast dependency graph linting for Gradle projects",
+    "packaging": "jar",
+    "javaVersion": "11"
+  },
   {
     "gradlePath": ":modulecheck-finding:name",
     "group": "com.rickbusarow.modulecheck",
@@ -175,6 +199,22 @@
     "packaging": "jar",
     "javaVersion": "11"
   },
+  {
+    "gradlePath": ":modulecheck-rule:impl-factory",
+    "group": "com.rickbusarow.modulecheck",
+    "artifactId": "modulecheck-rule-impl-factory",
+    "description": "Fast dependency graph linting for Gradle projects",
+    "packaging": "jar",
+    "javaVersion": "11"
+  },
+  {
+    "gradlePath": ":modulecheck-rule:testing",
+    "group": "com.rickbusarow.modulecheck",
+    "artifactId": "modulecheck-rule-testing",
+    "description": "Fast dependency graph linting for Gradle projects",
+    "packaging": "jar",
+    "javaVersion": "11"
+  },
   {
     "gradlePath": ":modulecheck-runtime:api",
     "group": "com.rickbusarow.modulecheck",
@@ -303,4 +343,4 @@
     "packaging": "jar",
     "javaVersion": "11"
   }
-]
+]

build-logic/gradle.properties

@@ -21,3 +21,4 @@ android.useAndroidX=true
 kotlin.code.style=official
 kotlin.caching.enabled=true
 kotlin.incremental=true
+kapt.include.compile.classpath=false

build.gradle.kts

@@ -54,7 +54,7 @@ moduleCheck {
     depths.enabled = true
     graphs {
       enabled = true
-      outputDir = File(buildDir, "reports/modulecheck/graphs").path
+      // outputDir = File(buildDir, "reports/modulecheck/graphs").path
     }
   }
 }

detekt/detekt-baseline.xml

@@ -21,3 +21,4 @@ android.useAndroidX=true
 kotlin.code.style=official
 kotlin.caching.enabled=true
 kotlin.incremental=true
+kapt.include.compile.classpath=false

gradle.properties

@@ -28,7 +28,6 @@ import modulecheck.utils.lazyDeferred
 import java.io.File
 
 data class DepthFinding(
-  override val findingName: FindingName,
   override val dependentProject: McProject,
   override val dependentPath: StringProjectPath,
   val depth: Int,
@@ -37,6 +36,8 @@ data class DepthFinding(
   override val buildFile: File
 ) : Finding, Comparable<DepthFinding> {
 
+  override val findingName = NAME
+
   override val message: String
     get() = "The longest path between this module and its leaf nodes"
   override val positionOrNull: LazyDeferred<Position?> = lazyDeferred { null }
@@ -77,4 +78,8 @@ data class DepthFinding(
       "sourceSetName=$sourceSetName" +
       ")"
   }
+
+  companion object {
+    val NAME = FindingName("project-depth")
+  }
 }

modulecheck-api/src/main/kotlin/modulecheck/api/DepthFinding.kt

@@ -86,7 +86,6 @@ data class ProjectDepth(
   private val treeCache = SafeCache<SourceSetName, Set<ProjectDepth>>()
 
   fun toFinding(name: FindingName): DepthFinding = DepthFinding(
-    findingName = name,
     dependentProject = dependentProject,
     dependentPath = dependentPath,
     depth = depth,

modulecheck-api/src/main/kotlin/modulecheck/api/context/Depths.kt

@@ -13,20 +13,14 @@
  * limitations under the License.
  */
 
-package modulecheck.core.context
+package modulecheck.api.context
 
 import kotlinx.coroutines.flow.asFlow
 import kotlinx.coroutines.flow.filter
 import kotlinx.coroutines.flow.flattenMerge
 import kotlinx.coroutines.flow.map
 import kotlinx.coroutines.flow.toList
 import kotlinx.coroutines.flow.toSet
-import modulecheck.api.context.anvilGraph
-import modulecheck.api.context.anvilScopeContributionsForSourceSetName
-import modulecheck.api.context.classpathDependencies
-import modulecheck.api.context.declarations
-import modulecheck.api.context.dependencySources
-import modulecheck.api.context.jvmFilesForSourceSetName
 import modulecheck.parsing.gradle.model.ConfigurationName
 import modulecheck.parsing.gradle.model.ConfiguredProjectDependency
 import modulecheck.parsing.gradle.model.SourceSetName

…in/modulecheck/core/context/MustBeApi.kt …lin/modulecheck/api/context/MustBeApi.ktmodulecheck-core/src/main/kotlin/modulecheck/core/context/MustBeApi.kt renamed to modulecheck-api/src/main/kotlin/modulecheck/api/context/MustBeApi.kt modulecheck-core/src/main/kotlin/modulecheck/core/context/MustBeApi.kt renamed to modulecheck-api/src/main/kotlin/modulecheck/api/context/MustBeApi.kt

@@ -13,16 +13,11 @@
  * limitations under the License.
  */
 
-package modulecheck.core.internal
+package modulecheck.api.context
 
 import kotlinx.coroutines.flow.filter
 import kotlinx.coroutines.flow.filterIsInstance
 import kotlinx.coroutines.flow.toSet
-import modulecheck.api.context.anvilGraph
-import modulecheck.api.context.anvilScopeContributionsForSourceSetName
-import modulecheck.api.context.declarations
-import modulecheck.api.context.dependents
-import modulecheck.api.context.referencesForSourceSetName
 import modulecheck.parsing.gradle.model.ConfiguredProjectDependency
 import modulecheck.parsing.gradle.model.SourceSetName
 import modulecheck.parsing.source.Generated

…kotlin/modulecheck/core/internal/uses.kt …n/kotlin/modulecheck/api/context/uses.ktmodulecheck-core/src/main/kotlin/modulecheck/core/internal/uses.kt renamed to modulecheck-api/src/main/kotlin/modulecheck/api/context/uses.kt modulecheck-core/src/main/kotlin/modulecheck/core/internal/uses.kt renamed to modulecheck-api/src/main/kotlin/modulecheck/api/context/uses.kt

@@ -13,7 +13,7 @@
  * limitations under the License.
  */
 
-package modulecheck.core.kapt
+package modulecheck.config.internal
 
 import modulecheck.config.CodeGeneratorBinding
 import modulecheck.parsing.gradle.model.PluginDefinition