fix the runtime classpath for the plugin

Author: RBusarow

build-logic/mcbuild/build.gradle.kts

@@ -30,21 +30,21 @@ val kotlinVersion = libs.versions.kotlin.get()
 dependencies {
 
   compileOnly(gradleApi())
+  compileOnly(libs.kotlin.gradle.plug)
 
   implementation(libs.benManes.gradle)
   implementation(libs.detekt.gradle)
-  implementation(libs.dropbox.dependencyGuard)
   implementation(libs.dokka.gradle)
+  implementation(libs.dropbox.dependencyGuard)
   implementation(libs.google.dagger.api)
   implementation(libs.google.ksp)
   implementation(libs.kotlin.compiler)
-  implementation(libs.kotlin.gradle.plug)
   implementation(libs.kotlinx.knit)
   implementation(libs.ktlint.gradle)
   implementation(libs.scabbard)
   implementation(libs.square.anvil.gradle)
-  implementation(libs.vanniktech.publish)
   implementation(libs.square.moshi)
+  implementation(libs.vanniktech.publish)
 
   ksp(libs.square.moshi.codegen)
 }

build-logic/mcbuild/src/main/kotlin/mcbuild.clean.gradle.kts

@@ -20,6 +20,8 @@ plugins {
 // delete any empty directories
 tasks.withType<Delete> {
 
+  notCompatibleWithConfigurationCache("Delete does not support configuration cache")
+
   doLast {
 
     val subprojectDirs = subprojects

build-logic/mcbuild/src/main/kotlin/modulecheck/builds/anvil.kt

@@ -37,6 +37,6 @@ fun Project.applyAnvil(anvil: Boolean, dagger: Boolean) {
 
   dependencies {
     "compileOnly"(project.libsCatalog.dependency("javax-inject"))
-    "implementation"(project.libsCatalog.dependency("google-dagger-api"))
+    "compileOnly"(project.libsCatalog.dependency("google-dagger-api"))
   }
 }

build-logic/mcbuild/src/main/kotlin/modulecheck/builds/dagger.kt

@@ -33,7 +33,7 @@ fun Project.applyDagger(anvil: Boolean, dagger: Boolean) {
 
   dependencies {
     "compileOnly"(project.libsCatalog.dependency("javax-inject"))
-    "implementation"(project.libsCatalog.dependency("google-dagger-api"))
+    "compileOnly"(project.libsCatalog.dependency("google-dagger-api"))
     "kapt"(project.libsCatalog.dependency("google-dagger-compiler"))
   }
 }

build-logic/mcbuild/src/main/kotlin/modulecheck/builds/publishing.kt

@@ -20,9 +20,13 @@ import com.vanniktech.maven.publish.JavadocJar.Dokka
 import com.vanniktech.maven.publish.KotlinJvm
 import com.vanniktech.maven.publish.MavenPublishBaseExtension
 import com.vanniktech.maven.publish.SonatypeHost.DEFAULT
+import com.vanniktech.maven.publish.tasks.JavadocJar
+import com.vanniktech.maven.publish.tasks.SourcesJar
 import org.gradle.api.Project
 import org.gradle.api.publish.PublishingExtension
 import org.gradle.api.publish.maven.MavenPublication
+import org.gradle.api.publish.maven.tasks.PublishToMavenRepository
+import org.gradle.api.tasks.bundling.Jar
 import org.gradle.kotlin.dsl.apply
 import org.gradle.kotlin.dsl.configure
 import org.gradle.plugins.signing.Sign
@@ -85,10 +89,6 @@ fun Project.configurePublishing(
       }
   }
 
-  tasks.withType(Sign::class.java) {
-    notCompatibleWithConfigurationCache("Signing cannot be cached")
-  }
-
   tasks.register("checkVersionIsSnapshot") {
     doLast {
       val expected = "-SNAPSHOT"
@@ -98,4 +98,21 @@ fun Project.configurePublishing(
       }
     }
   }
+
+  tasks.withType(PublishToMavenRepository::class.java).configureEach {
+    notCompatibleWithConfigurationCache("See https://github.com/gradle/gradle/issues/13468")
+  }
+
+  tasks.withType(Jar::class.java).configureEach {
+    notCompatibleWithConfigurationCache("")
+  }
+  tasks.withType(SourcesJar::class.java).configureEach {
+    notCompatibleWithConfigurationCache("")
+  }
+  tasks.withType(JavadocJar::class.java).configureEach {
+    notCompatibleWithConfigurationCache("")
+  }
+  tasks.withType(Sign::class.java).configureEach {
+    notCompatibleWithConfigurationCache("")
+  }
 }

build.gradle.kts

@@ -60,6 +60,14 @@ moduleCheck {
   }
 }
 
+// Hack for ensuring that when 'publishToMavenLocal' is invoked from the root project,
+// all subprojects are published.  This is used in plugin tests.
+val publishToMavenLocal by tasks.registering {
+  subprojects.forEach { sub ->
+    dependsOn(sub.tasks.matching { it.name == "publishToMavenLocal" })
+  }
+}
+
 tasks.matching { it.name == "ktlintFormat" }.configureEach {
   dependsOn(gradle.includedBuild("build-logic").task(":ktlintFormat"))
 }

detekt/detekt-config.yml

@@ -507,7 +507,7 @@ style:
     customMessage: ''
   ForbiddenImport:
     active: true
-    imports: [ 'groovy.xml.XmlParser' ]
+    imports: [ 'groovy.xml.XmlParser', 'com.android.build.*' ]
     forbiddenPatterns: ''
   ForbiddenMethodCall:
     active: false

gradle/libs.versions.toml

@@ -1,6 +1,6 @@
 [versions]
 
-androidTools = "7.2.0"
+androidTools = "7.1.3"
 
 androidx-compose = "1.1.0-alpha04"
 androidx-fragment = "1.3.6"

modulecheck-api/build.gradle.kts

@@ -24,11 +24,8 @@ mcbuild {
 
 dependencies {
 
-  api(libs.kotlin.compiler)
   api(libs.kotlinx.coroutines.core)
   api(libs.kotlinx.coroutines.jvm)
-  api(libs.rickBusarow.dispatch.core)
-  api(libs.semVer)
 
   api(project(path = ":modulecheck-finding:api"))
   api(project(path = ":modulecheck-finding:name"))
@@ -38,9 +35,7 @@ dependencies {
   api(project(path = ":modulecheck-project:api"))
   api(project(path = ":modulecheck-utils"))
 
-  implementation(libs.groovy)
-  implementation(libs.groovyXml)
-  implementation(libs.kotlin.reflect)
+  implementation(libs.kotlin.compiler)
 
   testImplementation(libs.bundles.hermit)
   testImplementation(libs.bundles.jUnit)

modulecheck-api/dependencies/runtimeClasspath.txt

@@ -1,4 +1,3 @@
-com.google.dagger:dagger:2.42
 com.rickbusarow.dispatch:dispatch-core:1.0.0-beta10
 com.squareup.anvil:annotations:2.4.0
 javax.inject:javax.inject:1