|
| 1 | +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 |
| 2 | +From: Oliver Simons <osimons@nvidia.com> |
| 3 | +Date: Tue, 22 Jul 2025 11:02:28 +0200 |
| 4 | +Subject: [PATCH] Enable CUDA Graphs for gemma3n. |
| 5 | + |
| 6 | +Similar to |
| 7 | +https://github.com/ggml-org/llama.cpp/pull/14741, |
| 8 | +though ollama has a slightly different model graph |
| 9 | +than llama.cpp which requires different workaround |
| 10 | +checks. |
| 11 | +--- |
| 12 | + ggml/src/ggml-cuda/ggml-cuda.cu | 16 ++++++++++++---- |
| 13 | + 1 file changed, 12 insertions(+), 4 deletions(-) |
| 14 | + |
| 15 | +diff --git a/ggml/src/ggml-cuda/ggml-cuda.cu b/ggml/src/ggml-cuda/ggml-cuda.cu |
| 16 | +index 2b9fabf4..28ccf4be 100644 |
| 17 | +--- a/ggml/src/ggml-cuda/ggml-cuda.cu |
| 18 | ++++ b/ggml/src/ggml-cuda/ggml-cuda.cu |
| 19 | +@@ -2474,6 +2474,9 @@ static bool check_node_graph_compatibility_and_refresh_copy_ops(ggml_backend_cud |
| 20 | + // Loop over nodes in GGML graph to obtain info needed for CUDA graph |
| 21 | + cuda_ctx->cuda_graph->cpy_dest_ptrs.clear(); |
| 22 | + |
| 23 | ++ const std::string gemma3n_per_layer_proj_src1_name = " (reshaped)"; |
| 24 | ++ const std::string gemma3n_node_name = "node_"; |
| 25 | ++ |
| 26 | + for (int i = 0; i < cgraph->n_nodes; i++) { |
| 27 | + ggml_tensor * node = cgraph->nodes[i]; |
| 28 | + |
| 29 | +@@ -2495,12 +2498,17 @@ static bool check_node_graph_compatibility_and_refresh_copy_ops(ggml_backend_cud |
| 30 | + #endif |
| 31 | + } |
| 32 | + |
| 33 | +- if (node->op == GGML_OP_ADD && node->src[1] && node->src[1]->ne[1] > 1) { |
| 34 | +- // disable CUDA graphs for batch size > 1 for now. |
| 35 | +- // Changes in batch size or context size can cause changes to the grid size of some kernels. |
| 36 | ++ // workarounds to exclude Gemma3n's `project_per_layer_input` operation from the batch-size heuristic, specific to ollama's implementation of gemma3n |
| 37 | ++ // number of layers is different for per_layer_proj between gemma3n:2b and gemma3n:4b, which is why we don't check that value here |
| 38 | ++ if (node->op == GGML_OP_ADD && node->src[1] && node->src[1]->ne[1] > 1 && !(node->ne[0] == 256 |
| 39 | ++ && node->ne[2] == 1 |
| 40 | ++ && node->ne[3] == 1 |
| 41 | ++ && node->src[0] ? std::string(node->src[0]->name).find(gemma3n_node_name) != std::string::npos : false |
| 42 | ++ && node->src[1] ? node->src[1]->name == gemma3n_per_layer_proj_src1_name : false)) { |
| 43 | ++ // Generally, changes in batch size or context size can cause changes to the grid size of some kernels. |
| 44 | + use_cuda_graph = false; |
| 45 | + #ifndef NDEBUG |
| 46 | +- GGML_LOG_DEBUG("%s: disabling CUDA graphs due to batch size > 1 [%s] [%ld %ld %ld %ld]\n", __func__, node->name, node->ne[0], node->ne[1], node->ne[2], node->ne[3]); |
| 47 | ++ GGML_LOG_INFO("%s: disabling CUDA graphs due to batch size > 1 [%s] [%ld %ld %ld %ld]\n", __func__, node->name, node->ne[0], node->ne[1], node->ne[2], node->ne[3]); |
| 48 | + #endif |
| 49 | + } |
| 50 | + |
0 commit comments