Skip to content

Commit 6f98d17

Browse files
authored
Merge pull request googleapis#2992 from garye/patch-1
Remove invalid chunk validation
2 parents b1a7046 + d0af421 commit 6f98d17

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

bigtable/google/cloud/bigtable/row_data.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,8 +366,6 @@ def _validate_chunk_row_in_progress(self, chunk):
366366
"""Helper for :meth:`_validate_chunk`"""
367367
assert self.state == self.ROW_IN_PROGRESS
368368
self._validate_chunk_status(chunk)
369-
if not chunk.HasField('commit_row') and not chunk.reset_row:
370-
_raise_if(not chunk.timestamp_micros or not chunk.value)
371369
_raise_if(chunk.row_key and
372370
chunk.row_key != self._row.row_key)
373371
_raise_if(chunk.HasField('family_name') and

bigtable/unit_tests/test_row_data.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -416,20 +416,6 @@ def test_invalid_empty_chunk(self):
416416
with self.assertRaises(InvalidChunk):
417417
prd.consume_next()
418418

419-
def test_invalid_empty_second_chunk(self):
420-
from google.cloud.bigtable.row_data import InvalidChunk
421-
422-
chunks = _generate_cell_chunks(['', ''])
423-
first = chunks[0]
424-
first.row_key = b'RK'
425-
first.family_name.value = 'A'
426-
first.qualifier.value = b'C'
427-
response = _ReadRowsResponseV2(chunks)
428-
iterator = _MockCancellableIterator(response)
429-
prd = self._make_one(iterator)
430-
with self.assertRaises(InvalidChunk):
431-
prd.consume_next()
432-
433419

434420
class TestPartialRowsData_JSON_acceptance_tests(unittest.TestCase):
435421

0 commit comments

Comments
 (0)