Updated PubSub to align with 0.11.0 #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arlodotexe
commented
Dec 22, 2021
| @@ -48,7 +48,7 @@ public Task PublishAsync(string topic, byte[] message, CancellationToken cancel | |||
| url.Append("/api/v0/pubsub/pub"); | |||
| url.Append("?arg="); | |||
| url.Append(System.Net.WebUtility.UrlEncode(topic)); | |||
| url.Append("&arg="); | |||
| url.Append("&data="); | |||
There was a problem hiding this comment.
This commit does not conform to the 0.0.11 API changes and should be disregarded entirely. See eec74ba instead
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the PubSub APIs to work with the recent 0.11.0 release.
The biggest change in this PR is the removal of support for .NET Framework 4.5 and .NET Standard 1.4. Pubsub now makes heavy use of multibase encoding, which APIs are bare to nonexistent in most of .NET.
Instead of rolling my own, I used the IPFS recommended cs-multibase library, This library is only available on .NET Standard 2.0. For my purposes, this works more than fine. netstandard 1.4 is starting to show its age and .NET Framework supports netstandard2.0 starting in 4.6.1. Additionally,
net45read EOL as of April 22nd, 2022.This does mean that the rest of the IPFS libraries that use this package will need to be updated before merging upstream.
Edit: I don't expect this PR to get merged any time soon. I'm working with the IPFS team to get this repo imported into the IPFS shipyard so the community can maintain it again.