Skip to content

Commit

Permalink
src: remove base64 from process.versions
Browse files Browse the repository at this point in the history
The `base64` dependency was previously removed along with the update
script (`tools/dep_updaters/update-base64.sh`) but the generated header,
`src/base64_version.h` was left behind and `process.versions` was still
listing the last version of `base64` that was included in Node.js before
it was removed

Refs: nodejs#52714
  • Loading branch information
richardlau committed Jun 13, 2024
1 parent 756b397 commit b06b82f
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 11 deletions.
6 changes: 0 additions & 6 deletions src/base64_version.h

This file was deleted.

2 changes: 0 additions & 2 deletions src/node_metadata.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#include "acorn_version.h"
#include "ada.h"
#include "ares.h"
#include "base64_version.h"
#include "brotli/encode.h"
#include "cjs_module_lexer_version.h"
#include "llhttp.h"
Expand Down Expand Up @@ -112,7 +111,6 @@ Metadata::Versions::Versions() {

acorn = ACORN_VERSION;
cjs_module_lexer = CJS_MODULE_LEXER_VERSION;
base64 = BASE64_VERSION;
uvwasi = UVWASI_VERSION_STRING;

#if HAVE_OPENSSL
Expand Down
3 changes: 1 addition & 2 deletions src/node_metadata.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ namespace node {
V(simdutf) \
V(ada) \
NODE_VERSIONS_KEY_UNDICI(V) \
V(cjs_module_lexer) \
V(base64)
V(cjs_module_lexer)

#if HAVE_OPENSSL
#define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl)
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-process-versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const expected_keys = [
'simdutf',
'ada',
'cjs_module_lexer',
'base64',
];

const hasUndici = process.config.variables.node_builtin_shareable_builtins.includes('deps/undici/undici.js');
Expand Down

0 comments on commit b06b82f

Please sign in to comment.