From 317b894b122e2c45499d6a0032adc27d85f0dd99 Mon Sep 17 00:00:00 2001 From: Denys Otrishko Date: Sat, 25 Aug 2018 21:19:54 +0300 Subject: [PATCH] doc: add GitHub email set up link to COLLABORATOR_GUIDE PR-URL: https://github.com/nodejs/node/pull/22525 Reviewed-By: Refael Ackermann Reviewed-By: Trivikram Kamat Reviewed-By: Colin Ihrig Reviewed-By: George Adams Reviewed-By: Vse Mozhet Byt --- COLLABORATOR_GUIDE.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 8402d742a44a5d..478908c8b1d023 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -65,9 +65,9 @@ badge. For first-time contributors, check if the commit author is the same as the pull request author, and ask if they have configured their git -username and email to their liking as per [this guide][git-username]. -This is to make sure they would be promoted to "contributor" once -their pull request lands. +[username][git-username] and [email][git-email] to their liking. +This is to make sure they would be promoted to "contributor" once their +pull request lands. ### Closing Issues and Pull Requests @@ -889,5 +889,6 @@ If you cannot find who to cc for a file, `git shortlog -n -s ` may help. [git-node]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md [git-node-metadata]: https://github.com/nodejs/node-core-utils/blob/master/docs/git-node.md#git-node-metadata [git-username]: https://help.github.com/articles/setting-your-username-in-git/ +[git-email]: https://help.github.com/articles/setting-your-commit-email-address-in-git/ [node-core-utils-credentials]: https://github.com/nodejs/node-core-utils#setting-up-credentials [node-core-utils-issues]: https://github.com/nodejs/node-core-utils/issues