Skip to content

Commit e96de1a

Browse files
lrhnkevmoo
authored andcommitted
Remove upper case constants (flutter#72)
* Remove usage of upper-case constants. * update SDK constraint * remove stable from Travis config
1 parent 885d40c commit e96de1a

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
language: dart
22
dart:
33
- dev
4-
- stable
5-
64
dart_task:
75
- test: -p vm
86
- test: -p chrome,firefox

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.13.3+1
2+
3+
* Updated SDK version to 2.0.0-dev.17.0
4+
15
## 0.13.3
26

37
* Update the signatures of `FilteredElementList.indexOf` and

pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
name: html
2-
version: 0.13.3
2+
version: 0.13.3+1
33
author: Dart Team <misc@dartlang.org>
44
description: A library for working with HTML documents. Previously known as html5lib.
55
homepage: https://github.com/dart-lang/html
66
environment:
7-
sdk: '>=1.21.0 <2.0.0'
7+
sdk: '>=2.0.0-dev.17.0 <2.0.0'
88
dependencies:
99
csslib: '>=0.13.2 <0.15.0'
1010
source_span: '>=1.0.0 <2.0.0'

test/parser_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,11 @@ void main() {
112112

113113
/// Extract the name for the test based on the test input data.
114114
_nameFor(String input) {
115-
// Using JSON.decode to unescape other unicode characters
115+
// Using jsonDecode to unescape other unicode characters
116116
var escapeQuote = input
117117
.replaceAll(new RegExp('\\\\.'), '_')
118118
.replaceAll(new RegExp('\u0000'), '_')
119119
.replaceAll('"', '\\"')
120120
.replaceAll(new RegExp('[\n\r\t]'), '_');
121-
return JSON.decode('"$escapeQuote"');
121+
return jsonDecode('"$escapeQuote"');
122122
}

test/tokenizer_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,10 @@ void runTokenizerTest(Map testInfo) {
204204
}
205205

206206
Map unescape(Map testInfo) {
207-
// TODO(sigmundch,jmesserly): we currently use JSON.decode to unescape the
207+
// TODO(sigmundch,jmesserly): we currently use jsonDecode to unescape the
208208
// unicode characters in the string, we should use a decoding that works with
209209
// any control characters.
210-
decode(inp) => inp == '\u0000' ? inp : JSON.decode('"$inp"');
210+
decode(inp) => inp == '\u0000' ? inp : jsonDecode('"$inp"');
211211

212212
testInfo["input"] = decode(testInfo["input"]);
213213
for (var token in testInfo["output"]) {
@@ -244,7 +244,7 @@ void main() {
244244
if (!path.endsWith('.test')) continue;
245245

246246
var text = new File(path).readAsStringSync();
247-
var tests = JSON.decode(text);
247+
var tests = jsonDecode(text);
248248
var testName = pathos.basenameWithoutExtension(path);
249249
var testList = tests['tests'];
250250
if (testList == null) continue;

0 commit comments

Comments
 (0)