Skip to content

Commit 0a760d0

Browse files
authored
Merge pull request flutter#19 from dart-lang/make-FailingTest-public
Make FailingTest public.
2 parents 4033df1 + cdedf60 commit 0a760d0

File tree

3 files changed

+19
-14
lines changed

3 files changed

+19
-14
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 0.1.6
2+
3+
- Make `FailingTest` public, with the URI of the issue that causes
4+
the test to break.
5+
16
## 0.1.5
27

38
- Set max SDK version to `<3.0.0`, and adjust other dependencies.

lib/test_reflective_loader.dart

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const _AssertFailingTest assertFailingTest = const _AssertFailingTest();
2121
* A marker annotation used to annotate overridden test methods (so we cannot
2222
* rename them to `fail_`) which are expected to fail.
2323
*/
24-
const _FailingTest failingTest = const _FailingTest();
24+
const FailingTest failingTest = const FailingTest(null);
2525

2626
/**
2727
* A marker annotation used to instruct dart2js to keep reflection information
@@ -267,11 +267,11 @@ Future _runTest(ClassMirror classMirror, Symbol symbol) {
267267
typedef dynamic _TestFunction();
268268

269269
/**
270-
* A marker annotation used to instruct dart2js to keep reflection information
271-
* for the annotated classes.
270+
* A marker annotation used to annotate overridden test methods (so we cannot
271+
* rename them to `fail_`) which are expected to fail.
272272
*/
273-
class _ReflectiveTest {
274-
const _ReflectiveTest();
273+
class FailingTest {
274+
const FailingTest(String issueUri);
275275
}
276276

277277
/**
@@ -293,14 +293,6 @@ class _AssertFailingTest {
293293
const _AssertFailingTest();
294294
}
295295

296-
/**
297-
* A marker annotation used to annotate overridden test methods (so we cannot
298-
* rename them to `fail_`) which are expected to fail.
299-
*/
300-
class _FailingTest {
301-
const _FailingTest();
302-
}
303-
304296
/**
305297
* Information about a type based test group.
306298
*/
@@ -321,6 +313,14 @@ class _Group {
321313
}
322314
}
323315

316+
/**
317+
* A marker annotation used to instruct dart2js to keep reflection information
318+
* for the annotated classes.
319+
*/
320+
class _ReflectiveTest {
321+
const _ReflectiveTest();
322+
}
323+
324324
/**
325325
* A marker annotation used to annotate "solo" groups and tests.
326326
*/

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: test_reflective_loader
2-
version: 0.1.5
2+
version: 0.1.6
33

44
description: Support for discovering tests and test suites using reflection.
55
author: Dart Team <misc@dartlang.org>

0 commit comments

Comments
 (0)