-
Notifications
You must be signed in to change notification settings - Fork 271
/
reducer.test.ts
411 lines (361 loc) · 11.7 KB
/
reducer.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
import { Dispatch } from 'redux';
import isEqual from 'lodash/isEqual';
import * as actionCreators from '../src/redux/actionCreators';
import { EnqueuedAction, NetworkState } from '../src/types';
import createReducer, {
initialState,
networkSelector,
} from '../src/redux/createReducer';
import getSimilarActionInQueue from '../src/utils/getSimilarActionInQueue';
const networkReducer = createReducer();
const getState = (isConnected = false, ...actionQueue: EnqueuedAction[]) => ({
isConnected,
actionQueue,
isQueuePaused: false,
});
/** Actions used from now on to test different scenarios */
const prevActionToRetry1 = {
type: 'FETCH_DATA_REQUEST',
payload: {
id: '1',
},
meta: {
retry: true,
},
};
const prevActionToRetry2 = {
type: 'FETCH_OTHER_REQUEST',
payload: {
isFetching: true,
},
meta: {
retry: true,
},
};
const prevActionToRetry1WithDifferentPayload = {
type: 'FETCH_DATA_REQUEST',
payload: {
id: '2',
},
meta: {
retry: true,
},
};
describe('unknown action type', () => {
it('returns prevState on initialization', () => {
expect(networkReducer(undefined, { type: 'ACTION_I_DONT_CARE' })).toEqual(
initialState,
);
});
it('returns prevState if the action is not handled', () => {
expect(
networkReducer(initialState, { type: 'ANOTHER_ACTION_I_DONT_CARE' }),
).toEqual(initialState);
});
});
describe('CONNECTION_CHANGE action type', () => {
it('changes isConnected state properly', () => {
const mockAction = actionCreators.connectionChange(false);
expect(networkReducer(initialState, mockAction)).toEqual({
isConnected: false,
actionQueue: [],
isQueuePaused: false,
});
});
});
describe('OFFLINE_ACTION action type', () => {
describe('meta.retry !== true', () => {
it('should NOT add the action to the queue', () => {
const prevAction = {
type: 'FETCH_DATA_REQUEST',
payload: {
id: '1',
},
};
const anotherPrevAction = {
type: 'FETCH_DATA_REQUEST',
payload: {
id: '1',
},
meta: {
retry: false,
},
};
const action = actionCreators.fetchOfflineMode(prevAction);
const anotherAction = actionCreators.fetchOfflineMode(anotherPrevAction);
expect(networkReducer(initialState, action)).toEqual(initialState);
expect(networkReducer(initialState, anotherAction)).toEqual(initialState);
});
});
describe('meta.retry === true', () => {
describe('actions with DIFFERENT type', () => {
it('actions are pushed into the queue in order of arrival', () => {
const preAction = actionCreators.connectionChange(false);
const action1 = actionCreators.fetchOfflineMode(prevActionToRetry1);
const prevState = networkReducer(initialState, preAction);
let nextState = networkReducer(prevState, action1);
expect(nextState).toEqual({
isConnected: false,
actionQueue: [prevActionToRetry1],
isQueuePaused: false,
});
const action2 = actionCreators.fetchOfflineMode(prevActionToRetry2);
nextState = networkReducer(nextState, action2);
expect(nextState).toEqual(
getState(false, prevActionToRetry1, prevActionToRetry2),
);
});
});
describe('thunks that are the same with custom comparison function', () => {
function comparisonFn(action: any, actionQueue: EnqueuedAction[]) {
if (typeof action === 'object') {
return actionQueue.find(queued => isEqual(queued, action));
}
if (typeof action === 'function') {
return actionQueue.find(
queued =>
action.meta.name === queued.meta!.name &&
action.meta.args.id === queued.meta!.args.id,
);
}
return undefined;
}
const thunkFactory = (id: number, name: string, age: number) => {
function thunk(dispatch: Dispatch) {
dispatch({ type: 'UPDATE_DATA_REQUEST', payload: { id, name, age } });
}
thunk.meta = {
args: { id, name, age },
retry: true,
};
return thunk;
};
it(`should add thunks if function is same but thunks are modifying different items`, () => {
const prevState = getState(false, thunkFactory(1, 'Bilbo', 55));
const thunk = thunkFactory(2, 'Link', 54);
const wrappedThunk = actionCreators.fetchOfflineMode(thunk);
expect(getSimilarActionInQueue(thunk, prevState.actionQueue)).toEqual(
prevState.actionQueue[0],
);
const nextState = createReducer(comparisonFn)(prevState, wrappedThunk);
expect(nextState.actionQueue).toHaveLength(2);
});
it(`should replace a thunk if thunk already exists to modify same item`, () => {
const prevState = getState(false, thunkFactory(1, 'Bilbo', 55));
const thunk = thunkFactory(1, 'Bilbo', 65);
const wrappedThunk = actionCreators.fetchOfflineMode(thunk);
expect(getSimilarActionInQueue(thunk, prevState.actionQueue)).toEqual(
prevState.actionQueue[0],
);
const nextState = createReducer(comparisonFn)(prevState, wrappedThunk);
expect(nextState.actionQueue).toHaveLength(1);
});
});
describe('actions with the same type', () => {
it(`should remove the action and add it back at the end of the queue
if the action has the same payload`, () => {
const prevState = getState(
false,
prevActionToRetry1,
prevActionToRetry2,
);
const action = actionCreators.fetchOfflineMode(prevActionToRetry1);
const nextState = networkReducer(prevState, action);
expect(nextState).toEqual(
getState(false, prevActionToRetry2, prevActionToRetry1),
);
});
it(`should push the action if the payload is different`, () => {
const prevState = getState(
false,
prevActionToRetry2,
prevActionToRetry1,
);
const action = actionCreators.fetchOfflineMode(
prevActionToRetry1WithDifferentPayload,
);
expect(networkReducer(prevState, action)).toEqual(
getState(
false,
prevActionToRetry2,
prevActionToRetry1,
prevActionToRetry1WithDifferentPayload,
),
);
});
});
});
});
describe('REMOVE_ACTION_FROM_QUEUE action type', () => {
it('removes the action from the queue properly', () => {
const prevState = getState(
false,
prevActionToRetry2,
prevActionToRetry1,
prevActionToRetry1WithDifferentPayload,
);
// Different object references but same shape, checking that deep equal works correctly
const action = actionCreators.removeActionFromQueue({
...prevActionToRetry2,
});
expect(networkReducer(prevState, action)).toEqual(
getState(
false,
prevActionToRetry1,
prevActionToRetry1WithDifferentPayload,
),
);
});
});
describe('QUEUE_SEMAPHORE_CHANGE action type', () => {
it('Pauses the queue if semaphore is red', () => {
expect(
networkReducer(undefined, actionCreators.changeQueueSemaphore('RED')),
).toEqual({
...initialState,
isQueuePaused: true,
});
});
it('Resumes the queue if semaphore is green', () => {
expect(
networkReducer(undefined, actionCreators.changeQueueSemaphore('GREEN')),
).toEqual({
...initialState,
isQueuePaused: false,
});
});
});
describe('thunks', () => {
function fetchThunk(dispatch: Dispatch) {
dispatch({ type: 'FETCH_DATA_REQUEST' });
}
describe('FETCH_OFFLINE_MODE action type', () => {
describe('action with meta.retry !== true', () => {
it('should NOT add the action to the queue', () => {
const action = actionCreators.fetchOfflineMode(fetchThunk);
expect(networkReducer(initialState, action)).toEqual(initialState);
});
});
describe('action with meta.retry === true', () => {
it('should add the action to the queue if the thunk is different', () => {
const prevState = getState(false);
// Property 'meta' does not exist on type '(dispatch: Dispatch<AnyAction>) => void'
(fetchThunk as any).meta = {
retry: true,
};
const action = actionCreators.fetchOfflineMode(fetchThunk);
expect(networkReducer(prevState, action)).toEqual(
getState(false, fetchThunk),
);
});
it(`should remove the thunk and add it back at the end of the queue
if it presents the same shape`, () => {
const thunkFactory = (param: any) => {
function thunk1(dispatch: Dispatch) {
dispatch({ type: 'FETCH_DATA_REQUEST', payload: param });
}
return thunk1;
};
const thunk = thunkFactory('foo');
const prevState = getState(false, thunk);
const similarThunk = thunkFactory('bar');
(similarThunk as any).meta = {
retry: true,
};
const action = actionCreators.fetchOfflineMode(similarThunk);
const nextState = networkReducer(prevState, action);
expect(nextState).toEqual(getState(false, similarThunk));
});
});
});
describe('REMOVE_ACTION_FROM_QUEUE action type', () => {
it('removes the thunk from the queue properly', () => {
const prevState = getState(false, fetchThunk);
const action = actionCreators.removeActionFromQueue(fetchThunk);
expect(networkReducer(prevState, action)).toEqual(getState(false));
});
});
});
describe('dismiss feature', () => {
const actionEnqueued1 = {
type: 'FETCH_PAGE_REQUEST',
payload: {
id: '2',
},
meta: {
retry: true,
dismiss: ['NAVIGATE_BACK', 'NAVIGATE_TO_LOGIN'],
},
};
const actionEnqueued2 = {
type: 'FETCH_USER_REQUEST',
payload: {
id: '4',
},
meta: {
retry: true,
dismiss: ['NAVIGATE_TO_LOGIN'],
},
};
const actionEnqueued3 = {
type: 'FETCH_USER_REQUEST',
payload: {
id: '4',
},
meta: {
retry: true,
},
};
it('NAVIGATE_BACK dispatched, dismissing 1 action', () => {
const prevState = getState(
false,
actionEnqueued1,
actionEnqueued2,
actionEnqueued3,
);
const action = actionCreators.dismissActionsFromQueue('NAVIGATE_BACK');
expect(networkReducer(prevState, action)).toEqual(
getState(false, actionEnqueued2, actionEnqueued3),
);
});
it('NAVIGATE_TO_LOGIN dispatched, dismissing 2 actions', () => {
const prevState = getState(
false,
actionEnqueued1,
actionEnqueued2,
actionEnqueued3,
);
const action = actionCreators.dismissActionsFromQueue('NAVIGATE_TO_LOGIN');
expect(networkReducer(prevState, action)).toEqual(
getState(false, actionEnqueued3),
);
});
it("Any other action dispatched, no changes (although the middleware won't allow that)", () => {
const prevState = getState(
false,
actionEnqueued1,
actionEnqueued2,
actionEnqueued3,
);
const action = actionCreators.dismissActionsFromQueue('NAVIGATE_AWAY');
expect(networkReducer(prevState, action)).toEqual(
getState(false, actionEnqueued1, actionEnqueued2, actionEnqueued3),
);
});
});
describe('networkSelector', () => {
it('returns the correct shape', () => {
const state: { network: NetworkState } = {
network: {
isConnected: true,
actionQueue: [{ type: 'foo', payload: {} }],
isQueuePaused: false,
},
};
expect(networkSelector(state)).toEqual({
isConnected: true,
actionQueue: [{ type: 'foo', payload: {} }],
isQueuePaused: false,
});
});
});