Handle delay message from Exchange and non-existing Inbox message from Office365 #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks useful, what about merging it? |
rklec
suggested changes
Sep 26, 2024
| Assert.Null(result.RemoteMta); | ||
| Assert.Equal("mail.example.com", result.ReportingMta); | ||
| Assert.Equal("rui.lopes@example.com", result.FinalRecipient); | ||
| Assert.Equal("<Q8P3DY5EH0U4.ERW6TCCK5TMF3@example.com>", result.UndeliveredMessageId); |
Contributor
There was a problem hiding this comment.
Suggested change
| Assert.Equal("<Q8P3DY5EH0U4.ERW6TCCK5TMF3@example.com>", result.UndeliveredMessageId); | |
| Assert.Equal("Q8P3DY5EH0U4.ERW6TCCK5TMF3@example.com", result.UndeliveredMessageId); |
Tests fail otherwise.
I fixed it in my fork: rklec@330f3ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alter BounceDetectResult so it can handle delay messages from Exchange and non-existing inbox messages from Office 365. Also, added handling of unknown status codes so they don't result in an exception.