Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noramlize,Spectra #199

Open
lgatto opened this issue Apr 15, 2021 · 2 comments
Open

noramlize,Spectra #199

lgatto opened this issue Apr 15, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@lgatto
Copy link
Member

lgatto commented Apr 15, 2021

We have normalize,MSnExp in MSnbase, and from my own usage and the MetaboAnnotation vignette, the use is general. I would suggest we add a normalise,Spectra that scales all intensities between 0 and 1.

Or should we rather go for scale,Spectra?

@sgibb @jorainer - any comments/suggestions?

@lgatto lgatto added the enhancement New feature or request label Apr 15, 2021
@jorainer
Copy link
Member

I think scale might be more appropriate (or even scaleIntensities to tell what exactly the function is doing).

I think we would also need a parameter to specify the range to which scale, you're scaling to [0-1], I'm usually scaling to [0-100] to have percentages and I know there are people that scale to [0-10].

@lgatto
Copy link
Member Author

lgatto commented Apr 16, 2021

Yes for scaleIntensitites() - that will avoid quite a bit of confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants