remove redundant type argument and some refactoring

Author: zaneli

src/main/java/com/zaneli/qiita/QiitaExecutor.java

@@ -103,7 +103,7 @@ public <T extends QiitaResponse> PageableResponse<T> getPageableContents(
     try (InputStream in = response.getEntity().getContent()) {
       @SuppressWarnings("unchecked")
       T[] contents = JSON.decode(in, (Class<T[]>) Array.newInstance(responseType, 0).getClass());
-      return new PageableResponse<T>(this, params, responseType, contents, linkHeaderValues);
+      return new PageableResponse<>(this, params, responseType, contents, linkHeaderValues);
     }
   }
 

src/main/java/com/zaneli/qiita/model/response/PageableResponse.java

@@ -23,6 +23,9 @@ private static enum Rel {
     private Rel(String value) {
       this.value = value;
     }
+    String getValue() {
+        return value;
+    }
   }
 
   private final QiitaExecutor executor;
@@ -52,34 +55,34 @@ public T[] getContents() {
 
   public PageableResponse<T> getFirst() throws IOException, QiitaException {
     if (firstUri == null) {
-      return new NullPageableResponse<T>(responseType, contents);
+      return new NullPageableResponse<>(responseType);
     }
     return executor.getPageableContents(firstUri, params, responseType);
   }
 
   public PageableResponse<T> getPrev() throws IOException, QiitaException {
     if (prevUri == null) {
-      return new NullPageableResponse<T>(responseType, contents);
+      return new NullPageableResponse<>(responseType);
     }
     return executor.getPageableContents(prevUri, params, responseType);
   }
 
   public PageableResponse<T> getNext() throws IOException, QiitaException {
     if (nextUri == null) {
-      return new NullPageableResponse<T>(responseType, contents);
+      return new NullPageableResponse<>(responseType);
     }
     return executor.getPageableContents(nextUri, params, responseType);
   }
 
   public PageableResponse<T> getLast() throws IOException, QiitaException {
     if (lastUri == null) {
-      return new NullPageableResponse<T>(responseType, contents);
+      return new NullPageableResponse<>(responseType);
     }
     return executor.getPageableContents(lastUri, params, responseType);
   }
 
   private static URI retrieveUri(Rel rel, String[] linkHeaderValues) throws QiitaException {
-    Pattern pattern = Pattern.compile("^<(.+)>;\\s+rel=\"" + rel.value + "\"$");
+    Pattern pattern = Pattern.compile("^<(.+)>;\\s+rel=\"" + rel.getValue() + "\"$");
     for (String linkHeaderValue : linkHeaderValues) {
       String[] splitedLinkHeaderValues = linkHeaderValue.split(",");
       for (String splitedLinkHeaderValue : splitedLinkHeaderValues) {
@@ -99,7 +102,7 @@ private static URI retrieveUri(Rel rel, String[] linkHeaderValues) throws QiitaE
   private static class NullPageableResponse<T extends QiitaResponse> extends PageableResponse<T> {
     private final T[] emptyContent;
     @SuppressWarnings("unchecked")
-    private NullPageableResponse(Class<T> responseType, T[] orgContents) throws QiitaException {
+    NullPageableResponse(Class<T> responseType) throws QiitaException {
       super(null, Collections.<String, String>emptyMap(), responseType, null, new String[0]);
       this.emptyContent = (T[]) Array.newInstance(responseType, 0);
     }

src/test/java/com/zaneli/qiita/QiitaClientTestUtil.java

@@ -37,6 +37,7 @@ static void configureMock(
     configureMock(executor, statusCode, null);
   }
 
+  @SuppressWarnings({ "resource", "unused" })
   static void configureMock(
       final QiitaExecutor executor,
       final int statusCode,
@@ -65,7 +66,7 @@ static void configureMock(
       }
       {
         mockStatusLine.getStatusCode();
-        returns(statusCode);
+        returns(Integer.valueOf(statusCode));
       }
       {
         mockEntity.getContent();